This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch, libgfortran] Better format hash function

From: Jerry DeLisle <jvdelisle at verizon dot net>
To: Janne Blomqvist <blomqvist dot janne at gmail dot com>
Cc: Fortran List <fortran at gcc dot gnu dot org>, GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 04 Jun 2009 16:58:14 -0700
Subject: Re: [Patch, libgfortran] Better format hash function
References: <7b446c2e0906040910x2a90dc5dmb318591a5c2071cd@mail.gmail.com>

Janne Blomqvist wrote:

Hi,

the attached patch replaces the existing (too?) simple string hash
function with an almost equally simple but supposedly pretty well
working one by D.J. Bernstein.

Regtested on x86_64-unknown-linux-gnu, Ok for trunk?

Attached is a text file containing an extraction of all format strings from the gfortran.dg testsuite. I was planning to start with this and do some actual testing of the hash function so that we could objectively proceed with the tweaks.

Unfortunately, I have not had much time to proceed with this and I thought NEWUNIT is a higher priority for me. The file was extracted with a Python script. I was hoping to add to the test set the NIST suite as well as others to try to get a representative sampling. I doubt that gfortran.dg is very representative, but it is a starting place.

Regards,

Jerry

'("#",A,"#")'
'(A)'
'(A)'
'(A)'
'(i5)'
'(i5)'
'(b0)'
'(a,i0,a)'
'(o0)'
'(a,i0,a)'
'(z0)'
'(a,i0,a)'
'(b0)'
'(a,i0,a)'
'(o0)'
'(a,i0,a)'
'(z0)'
'(a,i0,a)'
'(b0)'
'(a,i0,a)'
'(o0)'
'(a,i0,a)'
'(z0)'
'(a,i0,a)'
'(10f8.3)'
'(10f8.3)'
'(10f8.3)'
'(a)'
'(a)'
'(a)'
'(i6, (t7, 6i2))'
'(i4)'
'(i2.2)'
'(3X, A, T1, A,/)'
'(A2,1X,A2)'
'("hello"/"world")'
'("hello",t1,"HELLO",1x,"!"/"world",tl12,"WORLD")'
"(n)"
"(n)"
'(a)'
'(a)'
'(80I1)'
"(1X,a,'xyz')"
"(1X,a,'xyz')"
'(2A3)'
'(F0.1)'
'(2hi=,i3)'
'(2hi=,i3)'
'(2hi=,i3)'
'(A, Q, A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'("simple  = ",i5)'
'("derived = ",i5)'
'(80a)'
'(80a)'
'(80a)'
'(80a)'
'(10I4)'
'(10I4)'
'(A)'
'(80a1)'
'(a)'
'(A$)'
"(I2)"
'(a)'
'(a)'
'(i0)'
'(i0)'
'(f0.2)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(3(2x,i4/)/3(3x,i6/))'
'(3(2x,i4/)/3(3x,i6/))'
'(A)'
'(/2i2)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(A)'
'(2I2)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(10f8.3)'
'(10f8.3)'
'(dp,f8.3,dc,f8.2,dp,f8.3)'
'(A)'
'(I2)'
'(I1)'
"(A)"
'(2A4)'
'(1X,2E12.3)'
'(1X,1P,2E12.3)'
'(g0.3)'
'(g0.9)'
'(g0.5)'
'(g0.8)'
'(g0.8)'
'(3E20.2e2)'
'(3E20.2e3)'
'(3E20.2e4)'
'(3E20.2e5)'
'(3E20.2e6)'
'(3E20.2e7)'
'(3E20.3e2)'
'(3E20.3e3)'
'(3E20.3e4)'
'(3E20.3e5)'
'(3E20.3e6)'
'(3E20.3e7)'
'(3E20.4e2)'
'(3E20.4e3)'
'(3E20.4e4)'
'(3E20.4e5)'
'(3E20.4e6)'
'(3E20.4e7)'
'(es6.0)'
'(A)'
'(A)'
'(A)'
'(A)'
'(3a)'
'(3a)'
'(3a)'
'(I50)'
'(I50)'
'(I50)'
'(I50)'
'(I50)'
"(1000(a,$))"
'(A)'
'(2f10.2)'
'(a)'
'(a)'
'(a)'
'(A)'
'(A)'
'(A)'
'(A2)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(3l6)'
"(a)"
'(a)'
'(a)'
'(a)'
'(A,I1)'
"(F6.3)"
"(I6)"
"(I6)"
'(9G10.6)'
'(9G10.6)'
'(3(2x,i4/)/3(3x,i6/))'
'(3(2x,i4/)/3(3x,i6/))'
"(a, i8)"
'(a10,tl6,2x,a2)'
'(a10,tl6,2x,a2)'
'(a10,tl6,2x,a2)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(20i4)'
'(20i4)'
"(f4,a6)"
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(80I1)'
'(a)'
"(1.0E-7,4.0E-3)"
'(A)'
'(3A4)'
'(3A4, 8A)'
'(4A8, "!")'
'(16A)'
'(8a)'
"(1pe9.2)"
"(1pe9.2)"
'("#",A,"#")'
'(a)'
"(a)"
"(a)"
'(a)'
'(a)'
'(2I4)'
'(3(2x,i4/)/3(3x,i6/))'
'(3(2x,i4/)/3(3x,i6/))'
'(6(i12/))'
'(a)'
'(a11)'
'(a11)'
'(a)'
'(a)'
'(a)'
'(a)'
'(I2)'
'(A)'
'(A15)'
'(E15.8)'
"(F10.4)"
'(I0)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
"(A)"
'(80I1)'
'(A)'
'(t50000,a,t1,a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
"(A,4F5.0)"
"(A,4I5)"
'(a8)'
"(a(1))"
'(a12/)'
'(4a12)'
'(a12/)'
'(a12/)'
'(a12/)'
'(1X,A,T1,A)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(T7,2F9.3)'
'(e12.5)'
"(a)"
"(a)"
"(a)"
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(A,2/,A)'
'(I2)'
'(I2)'
'(I2)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a3,i1)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
"(i7,(' abcd'))"
'(A34)'
'(A37)'
'(a)'
'(a)'
'(a)'
'(a)'
'(I2)'
'(I2)'
"(a)"
'(A6)'
'(A10)'
'(A1)'
'(4F10.2)'
'(4F10.2)'
'(4F10.2)'
'(4F10.2)'
"(i5)"
"(i5)"
"(i5)"
'(3L1)'
'(3I1)'
"(a)"
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(G10.3,A)'
'(G10.3,A)'
'(G10.3e1,a)'
'(E199.192,A)'
'(EN15.3,A)'
'(EN15.3,A)'
'(ES10.3,A)'
'(F10.8,A)'
'(1PE10.3,A)'
'(F10.3,A)'
'(F10.3,A)'
'(E10.3,A)'
'(EN15.3,A)'
'(2PE10.4,A)'
'(-2PE10.4,A)'
'(E10.1,A)'
'(a)'
'(a)'
'(3A4)'
'(3A4, 8A)'
'(4A8, "!")'
'(16A)'
'(8a)'
'(L1)'
'(L1)'
'(a)'
'(a)'
'(a)'
'(a040,t1,040a)'
'(a032,t2,a032t3,a032)'
'(a017,t1,a0017)'
"(L)"
"(L)"
"(L)"
"(L)"
"(L)"
"(L)"
"(L)"
"(L)"
"(L)"
"(L)"
"(L)"
"(L)"
"(L)"
"(L)"
"(L)"
"(L)"
"(nan,4.0)"
"(7.0,nan)"
"(+inFinity,4.0)"
"(7.0,-inFinity)"
"(+inf,4.0)"
"(7.0,-inf)"
'(a)'
'(i0)'
'(E15.0)'
'(D15.0)'
'(G15.0)'
'(2PE15.0)'
'(0PE15.0)'
'(1PE15.0)'
'(F15.0)'
'(80L1)'
'(4i2)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(4I3)'
'(4I3)'
'(a)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(a,t1,a)'
'(a)'
'(a)'
'(a)'
'(2a4)'
'(a)'
'(a)'
'(a8)'
'(a)'
'(3i2)'
'(a)'
'(a10)'
'(a)'
'(a)'
'(a)'
'(i5)'
'(i5)'
'(i5)'
'(i5)'
"(A)"
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(10f8.3)'
'(10f8.3)'
'(A,T2,A)'
'(6A)'
'(a)'
'(a)'
'(A)'
'(A)'
'(A)'
'(g20.14)'
'(6a1)'
"(A)"
'(6A)'
'(6A)'
'(6A)'
'(6A)'
'(2(e12.4e5, 2x))'
'(2(e12.4e5, 2x))'
'(f4,a6)'
'(d4,a6)'
'(e10.4)'
'(e10.4)'
'(e10.4)'
'(e10.4)'
'(A, Q, A)'
'(Q)'
'(4I2)'
'(A)'
'(A)'
'(A)'
'(A)'
'(A)'
'(Z4)'
'(Z5)'
'(Z9)'
'(Z17)'
'(Z2)'
'(Z8)'
'(B65)'
'(O4)'
'(2A)'
'(2A)'
'(2A)'
'(I4)'
'(I5)'
'(i0)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
"(g0,g0,g0)"
'(g0,g0,g0)'
'(5(a))'
'(10I5)'
'(a)'
'(a)'
'(a)'
'(80I1)'
"(4I4)"
"(4I4)"
'(I2)'
"(a)"
'(10f8.3)'
'(10f8.3)'
'(10f8.3)'
'(10f8.3)'
'(F12.5)'
'(F15.5)'
'(A)'
'(10A1)'
'(10A1)'
'(I4)'
'(I4)'
'(I4)'
'(ES12.3)'
'(EN12.3)'
'(9F9.5)'
'(9F9.5)'
'(18F9.5)'
'(18F9.5)'
'(f10.3,s,f10.3,sp,f10.3,ss,f10.3)'
'(f10.3,dc,f10.3,dp,f10.3)'
'(a)'
'(a)'
'(f9.2,1x,f8.2,2x,f11.7)'
'(100i1)'
'(100i1)'
'(f16.10)'
'(F4.1)'
'(SS,F4.1)'
'(SP,F4.1)'
'(A)'
'(2A)'
'(2A)'
'(A,$)'
'(A)'
'(A)'
'(            NaN,            NaN)'
'(            NaN,            NaN)'
'(      +Infinity,      -Infinity)'
'(  0.0000000    , -0.0000000    )'
'(4(a,/),a)'
'(a)'
'(T20,A3,  T1,A4,  T5,A2,  T7,A2,  T9,A4, T17,A2)'
'(a)'
'(a)'
'(3(a))'
'(3(a))'
'(3(a))'
"(A)"
'(10I5)'
'(10I5)'
'(10I5)'
'(A)'
'(2I2)'
"(g0,g0,g0)"
'(3A4)'
'(3A4, 8A)'
'(4A8, "!")'
'(16A)'
'(8a)'
'(55L1)'
'(55L1)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(L1)'
'(L1)'
'(L1)'
"('#',F0.2,'#')"
"('#',F0.2,'#')"
'("#",A,"#")'
'(BZ,E11.0)'
'(BN,E11.0)'
'(BN,E11.0)'
'(E11.0)'
'(BZ,E11.0)'
'(3(2x,i4/)/3(4x,i9/))'
'(3a)'
'(3a)'
'(10f8.3)'
'(dc,10f8.3)'
'(dp,10f8.3)'
'(10f8.3)'
'(10f8.3)'
'(80I1)'
'(Q)'
"(2A4)"
"(A4)(A5)"
"(A5)"
'(4I4)'
'(4I4)'
'(a)'
'(A)'
'(A)'
'(A)'
'(a)'
"(str)"
'(A,$)'
'(A)'
'(A)'
'(a)'
'(a5)'
"(F6.3)"
'(i6)'
'(i6)'
'(i6)'
'(i6)'
'(i6)'
'(i6)'
'(i6)'
'(i6)'
'(i6)'
'(i6)'
'(i6)'
'(f4,a6)'
'(d10,a6)'
'(i6)'
'(i6)'
'(i6)'
'(i6)'
'(i6)'
'(i6)'
'(i6)'
"(A)"
"(A)"
"(A)"
'(10(I3))'
"(A)"
'(a)'
'(a)'
'(a)'
'(f3.3)'
'(a)'
'(f8.3)'
'(a)'
'(f3.3)'
'(f3.3)'
'(a)'
"(A)"
"(A)"
'("1 2 3 4 5 6 7 8 9")'
'("9 8 7 6")'
'(10(I3))'
'(10(I3))'
'(10(I3))'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(i4)'
'(i2.2)'
'(A)'
'("1 2 3 4 5 6 7 8 9")'
'("9 8 7 6")'
'(6F8.3)'
'(6F8.3)'
'(6F8.3)'
'(a)'
'(a)'
'(a)'
'(a)'
'(i12)'
"(A)"
"(A)"
"(I2)"
'(10I4)'
'(10I4)'
'(10I4)'
'(10I4)'
'(10I4)'
'(10I4)'
'(10I4)'
'(10I4)'
'(9F9.5)'
'(9F9.5)'
'(9F9.5)'
'(9F9.5)'
'(18F9.5)'
'(18F9.5)'
'(18F9.5)'
'(18F9.5)'
'(F40.35)'
'(F40.35)'
'(F15.10)'
'(F15.10)'
'(F15.10)'
'(F15.10)'
'(F15.10)'
'(F40.35)'
'(F15.10)'
'(F15.10)'
'(F15.10)'
'(F15.10)'
'(F15.10)'
'(F20.15)'
'(F20.15)'
'(G20.10E5)'
'(G20.10E5)'
'(F20.15)'
'(F20.15)'
'(G20.10E5)'
'(G20.10E5)'
'(o0)'
'(A,Z8)'
'(A,Z8)'
'(A,Z8)'
'(A)'
'(A)'
'(1P,E13.5)'
'(E13.5)'
'(F15.5)'
"(' (', F15.5, ',' F15.5, ') ')"
'(a,1x,(t7, 3a))'
'(a)'
'(2hi=,i3)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(a)'
'(A,2X)'
'(A)'
'(A)'
'(TL2,A)'
'(a)'
'(A)'
'(A)'
'(A)'
'(a)'
"(i22)"
'(5a16)'
'(i3)'
"(e9.2)"
"(d9.2)"
'(4a1)'
'(4a1)'
'(4i2)'
'(4i2)'
"(a,t1,a,a)"
"(a,t1,a)"
"(a)"
"(a)"
"(a)"
"(2f5.3)"
"(a" // ")"
"(f5.3)"
"(g0,g0,g0)"
'(g0,g0,g0)'
'(1x,a,g0,a)'
"(g0,g0,g0,g0)"
"(g0,g0,',',g0,g0)"
"(1.2345001,2.4567001)"
'(A)'

References:
- [Patch, libgfortran] Better format hash function
  - From: Janne Blomqvist

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]