This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran] PR38538 - ICE with elemental character function


Daniel,

First, thanks for the review.  I'm sitting at Frankfurt airport
waiting for a flight to Korea, so I cannot reply in detail to your
points.


> Not sure if I got this one correctly, but it seems to me this handles the
> concatenation operator; if not, I do not see why we simply add the lengths
> and are done.  If I'm right, maybe we should at least assert it here?

Well, I am adding the lengths but am converting the expressions
recursively.  I haven't thought this through entirely but I suspect
that this function might be the best general purpose character length
calculator that we have.  I might just try rolling it out into other
places that have cause trouble in the past.

Assert what, exactly?
>
> +         if (formal->sym)
> +         gfc_add_interface_mapping (&mapping, formal->sym, NULL,
> arg->expr);
>
> Indentation looks wrong, but may be my mail program or same tabs thing.

I'll check before committing.... whenever that may be!

Thanks again

Paul


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]