This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [vta, trunk] don't leak uninitialized stack state into output
Alexandre,
I have marked this mail for future attention - many thanks for putting
it right. Obviously, I need to understand why gfc_target_encode_expr
is not doing the right thing.
Cheers
Paul
On Fri, Mar 6, 2009 at 10:05 AM, Alexandre Oliva <aoliva@redhat.com> wrote:
>> On Sun, Mar 1, 2009 at 11:42 AM, Richard Guenther
>> <richard.guenther@gmail.com> wrote:
>>> I think zeroing the buffer completely before using it would match
>>> general programming style more appropriately
>
>> That's verging on obvious. ?OK by me.
>
> Unfortunately, the original patch wasn't quite right. ?It regressed
> gfortran.dg/widechar_intrinsics_8.f90, but I didn't realize that before
> it hit the branch :-(
>
> I spent some time trying to figure out why, but then I decided to try
> Richi's suggestion, and fixed it. ?I suppose gfc_target_encode_expr may
> be returning something other than the number of chars used up in the
> buffer.
>
> I'm leaving it at that. ?Here's the patch I'm installing in the trunk,
> followed by the patch for the branch (that combines reverting the broken
> patch and applying the trunk patch). ?In case you'd like to investigate
> the failure, applying the branch patch reversed would get you the broken
> compiler.
>
>
> --
> Alexandre Oliva ? ? ? ? ? http://www.lsd.ic.unicamp.br/~oliva/
> You must be the change you wish to see in the world. -- Gandhi
> Be Free! -- http://FSFLA.org/ ? FSF Latin America board member
> Free Software Evangelist ? ? ?Red Hat Brazil Compiler Engineer
>
>
--
The knack of flying is learning how to throw yourself at the ground and miss.
--Hitchhikers Guide to the Galaxy