Re: [Patch, fortran] PR34955 - transfer_assumed_size_1.f90: Valgrind error: invalid read of size 3

["Paul Richard Thomas" <paul dot richard dot thomas at gmail dot com>]

Dear Dominique,


> (coming from pr31608). I saw one regression on char_cast_1.f90 which needs some
> adjustment of the test, the following change allows it to pass:

Thanks, I forgot all about it.

> -! { dg-final { scan-tree-dump-times "5\\\]\\\[1\\\]" 2 "original" } }
> +! { dg-final { scan-tree-dump-times "6\\\]\\\[1\\\]" 2 "original" } }
>  ! { dg-final { cleanup-tree-dump "original" } }

That's right.
>
> From the comment the test seems fragile and should probably changed to
> something more robust.

There are one or two other tests like this in the testsuite.  I did
not see any alternative then and I do not see an alternative now.
That said, it is no big deal to change them as the corresponding
compiler code changes.  You will note that the testcase for this PR
was abreviated to reduce the risk of it having to be changed.  Maybe I
should do the same for char_cast_.f90

Thanks

Paul