Re: [vta, trunk?, fortran]

[Mikael Morin <mikael dot morin at tele2 dot fr>]

Alexandre Oliva wrote:
> On Nov 25, 2008, Mikael Morin <mikael.morin@tele2.fr> wrote:
> 
>> I think there are some missing parts in your patch.
>> The trans.h part for example.
> 
> It's at the end of the patch.
Yes, sorry. It wasn't displaying properly.

I'm not a reviewer, so you will need someone else's approval.
I have one comment though.
Would it be possible to move this:

+      GFC_TYPE_ARRAY_BASE_DECL (type, indirect) = base_decl;

here:

+  /* This will generate the base declarations we need to emit debug
+     information for this type.  FIXME: there must be a better way to
+     avoid divergence between compilations with and without debug
+     information.  */
+  {
+    struct array_descr_info info;
+    gfc_get_array_descr_info (fat_type, &info);
+    gfc_get_array_descr_info (build_pointer_type (fat_type), &info);
+  }
+

?

Otherwise, it looks like the latter part is useless and can be removed.

Mikael