This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [vta, trunk?, fortran]
- From: Mikael Morin <mikael dot morin at tele2 dot fr>
- To: Alexandre Oliva <aoliva at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Tue, 25 Nov 2008 14:59:27 +0100
- Subject: Re: [vta, trunk?, fortran]
- References: <or63mc5psw.fsf@livre.oliva.athome.lsd.ic.unicamp.br>
Hi,
Thanks for your contribution.
I think there are some missing parts in your patch.
The trans.h part for example.
Furthermore, as fortran has its own ChangeLog, you don't need to add the
fortran/ path in the ChangeLog.
Well, I'm not sure about the above, as I don't know how branches are
managed. I can see several ChangeLog.* in the gcc directory.
Mikael
Alexandre Oliva wrote:
> This patch fixes 204 -fcompare-debug failures in GCC fortran
> (including libgomp) testsuites.
>
> It fixes two separate issues, that each cause divergence in decl uids,
> which in turn lead to optimization differences in compilations with
> and without -g.
>
> 1. we didn't generate range types for multidimensional arrays when not
> generating debug info
>
> 2. we only generated base decls for array descriptors when emitting
> debug info
>
> I acknowledge these changes are somewhat wasteful, especially the
> second part, that's most certainly too conservative, but I figured I'm
> not sufficiently familiar with this front-end to figure out a better
> way to do it.
>
> Suggestions?
>
> I'm installing this in the VTA branch.
>
> Is this appropriate for the trunk?
>
>
>
> ------------------------------------------------------------------------
>
>