Re: [Patch, Fortran] PR 36322/36463

["Janus Weil" <jaydub66 at googlemail dot com>]

> Have patience - the few reviewers that there are have daytime jobs too.

I'm sorry. I din't want to be rude. Just trying to prevent the patch
from being forgotten ...


> This looks OK for trunk, subject a remark being resolved according
> unto conscience:
>
> It is conventional to tip a hat to the reporters in the "Contributed
> by" line in the test cases, unless the final result is very far
> removed from the original.  Whilst I am sure that Tobias and Dominique
> just want the bugs fixed, it helps in general if we acknowledge the
> reporter.  Your claim to fame is in the Changelog:-)

Well, sorry, I wasn't trying to claim anyone else's fame.

Actually I didn't give too much thought to whose name I'd be putting
into the testcases. And now that I do I'm still not quite sure who
would most deserve it.

I think the original test case on c.l.f. (which triggered both PRs,
but is still not fully fixed) was posted by James van Buskirk. Then
both Tobias and Dominique did contribute reduced or modified versions
of the original. And I think the two testcases included in the patch I
have mostly written myself (at least that's what I think, correct me
if I'm wrong). That's probably why I used my own name. Of course the
interfaces are the heart of the test case, and they are basically
copied from the original code.

So what do you suggest who deserves the 'fame'? (Probably James van
Buskirk, I'd think.)

Anyway I don't think there is all that much fame and glory in a test
case, and I really don't care whose name we put there. I just thought
it's convential to put in some name, so that one knows who to
ask/blame in case there is some problem with the test case or
whatever.

Maybe I misunderstood the meaning of the 'contributed by' line. In any
case I surely didn't want to offend or irritate anyone.

Honest apologies,
Janus