This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, Fortran] PR fortran/37749 ICE on array section with vector subscript
- From: "Paul Richard Thomas" <paul dot richard dot thomas at gmail dot com>
- To: "Mikael Morin" <mikael dot morin at tele2 dot fr>
- Cc: "correctifs gcc" <gcc-patches at gcc dot gnu dot org>, gfortran <fortran at gcc dot gnu dot org>
- Date: Fri, 31 Oct 2008 10:52:30 +0100
- Subject: Re: [Patch, Fortran] PR fortran/37749 ICE on array section with vector subscript
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=0wdnFQ/Z/WIPy99A8wFg7o5CI9VYbdRJTdrgYE37s48=; b=cFhqix/yogqXswI+Yubjjie1YrHEGOq4Cntebid994pH3ZTjf9HTClZN8PztAug/XO +ZKIIQTrd6LameyF+ANOZfvvDM29chkQ6ixEwqMKoK1tSVhNF68S8TNvWqAGKVsrqMCy rCJKmi7y974JhVZ48PKC9lRX3rGsQKQPYrPHA=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=dYigNwyME7BwOEmmKKpyBmUDGIT05b2QtQvUKZvUN7udDYOt30kvRH9bRYhA2nL5nw VLS/6D/ovgZq6sS3wMWfv3mQkKaSKuia6EUGoI9uoZ+8Si4xCu4nFyRjQlQ3eM5d/pm4 oN5cv+e5eIZuOeIjwW4oJIofJmEHT+kF8ArTQ=
- References: <490A0EB4.60707@tele2.fr>
Mikael,
I took action last night on this and PR37903 because I was concerned
that we were going to run out of time on stage 3. I'm sorry about
doubling up our effort. I tried to contact you before the commit but
failed. If you have any problem with what I committed, please get in
touch and we will put it right. You have been attributed in the
ChangeLogs:-)
Cheers
Paul
On Thu, Oct 30, 2008 at 8:44 PM, Mikael Morin <mikael.morin@tele2.fr> wrote:
> Hello,
>
> here comes the e-mail version of my patch posted on bugzilla:
> with a ChangeLog entry and the testcase.
>
> As a reminder, this patch looks for a NULL loop->to[n] before setting
> the temporary descriptor to check whether we are using a
> callee-allocated array or not.
> This prevents setting the descriptor with a NULL size (which segfaults).
>
> I didn't take the run-time check from the original testcase, as it is
> just a compilation failure.
>
> regression tested on x86_64-unknown-linux-gnu.
>
> Mikael
>
>
> 2008-10-30 Mikael Morin <mikael.morin@tele2.fr>
>
> PR fortran/37749
> * trans-array.c (gfc_trans_create_temp_array): Check whether
> there is one NULL loop->to[n] before setting the descriptor
> with the loop bounds.
>
> 2008-10-30 Mikael Morin <mikael.morin@tele2.fr>
>
> PR fortran/37749
> * gfortran.dg/vector_subscript_4.f90: New test.
>
--
The knack of flying is learning how to throw yourself at the ground and miss.
--Hitchhikers Guide to the Galaxy