This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: COMMON requires 4 bytes of padding at start
- From: "Janus Weil" <jaydub66 at googlemail dot com>
- To: "Tobias Burnus" <burnus at net-b dot de>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Mon, 22 Sep 2008 13:55:47 +0200
- Subject: Re: COMMON requires 4 bytes of padding at start
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=/rQy3/QP5/7S11DKdXX3afa5ezKN4+n9xhOyrU8zhqI=; b=ZlRxm7Qdd3Qfb4fiXy2W0L/x5XJIopAmYVr8VWw8ObqNnnu0AC1iOI5ITMljZorQTq h/M8x6MAyM2vInbMr+3KgOO0b3bsKhz2FJO/o1Ghqj3Q67EqHQdVnaLP29r+CqG+zBJd Mh2lrMJ9eaelAu5wS8qH58Cha0arfle5xj/YM=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=gs4bBBAJCzTRZ4obFU0XfFy2PrgM1aEbKMarJEllg6RQonxAk7HzcNr50D+4JuU2Ev GQY2McCGHGc60XunDsIXv3CO7donigm2E0yNzFfqm9r8kvXrlo4UVpSPXzJ9Lgbg4NSt xH4EzdpiEG9OGuSWsKI015+uO+uKuVWECsb/0=
- References: <20080920190759.GA26065@net-b.de> <854832d40809201505n1cfb57a9o8f9937371bff55b4@mail.gmail.com> <854832d40809201615x1d5d029akc0b7543eb4b6062a@mail.gmail.com> <48D6B49F.5070000@net-b.de>
2008/9/21 Tobias Burnus <burnus@net-b.de>:
> Janus Weil wrote:
>> I think this is much better.
>>
> That patch is OK for the the trunk with the following changes.
Committed as rev. 140546 (with the changes below). Thanks for the review.
> a) Can you add in
>
> +@item -Walign-commons
> +@opindex @code{Walign-commons}
> +@cindex warnings, alignment of COMMON blocks
> +@cindex alignment of COMMON blocks
> +By default, @command{gfortran} warns about any occasion of variables being
> +padded for proper alignment inside a COMMON block. This warning can be turned
> +off via @option{-Wno-align-commons}.
>
> a "See also -falign-commons." as the latter gives the background for this warning.
>
> b) For the following
>
>
> if (gfc_option.warn_align_commons)
> if (strcmp (common->name, BLANK_COMMON_NAME))
> gfc_warning ("Padding of %d bytes required before '%s' in "
>
>
> I get a warning that one should use "{ }", which stops compiling due to
> -Werror. Can you add the { } ?
>
> c) Just to make sure (because of (b)): Did you build + run the test
> suite with your modified patch? If not, you better do this before you
> commit.