This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: (new) Failure building GFortran (Cygwin)
- From: Angelo Graziosi <angelo dot graziosi at alice dot it>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org, gcc at gcc dot gnu dot org, Dave Korn <dave dot korn at artimi dot com>, gdr at integrable-solutions dot net
- Date: Tue, 08 Jul 2008 00:21:22 +0200
- Subject: Re: (new) Failure building GFortran (Cygwin)
- References: <486629E7.7030003@alice.it> <339c37f20806281308y78981c25h22fec3bddb77d60b@mail.gmail.com> <486F57D8.6060400@alice.it> <008a01c8dfab$344c0ca0$2708a8c0@CAM.ARTIMI.COM> <4871D596.5000105@alice.it> <m3d4lp35ej.fsf@google.com>
Ian Lance Taylor wrote:
It's valid, but it's not the right patch. The right patch is to use
XNEW and XCNEW from include/libiberty.h.
Gabriel Dos Reis in [1] wrote:
> The idiom is to use XCNEWVAR(T) for xcalloc(1, sizeof(T)),
> XNEWVAR(T) for xmalloc(sizeof(T)),...
Gulp! I am a little confused... XNEW or XNEWVAR, etc.?
In any case, my opinion is that this should solve:
--- gcc-4.4-20080704.orig/gcc/ggc-page.c 2008-06-29 06:39:16.000000000 +0200
+++ gcc-4.4-20080704/gcc/ggc-page.c 2008-07-05 12:00:20.906250000 +0200
@@ -799,7 +799,7 @@
alloc_size = GGC_QUIRE_SIZE * G.pagesize;
else
alloc_size = entry_size + G.pagesize - 1;
- allocation = xmalloc (alloc_size);
+ allocation = XNEWVAR(char, alloc_size);
page = (char *) (((size_t) allocation + G.pagesize - 1) &
-G.pagesize);
head_slop = page - allocation;
@@ -842,7 +842,7 @@
struct page_entry *e, *f = G.free_pages;
for (a = enda - G.pagesize; a != page; a -= G.pagesize)
{
- e = xcalloc (1, page_entry_size);
+ e = XCNEWVAR(struct page_entry, page_entry_size);
e->order = order;
e->bytes = G.pagesize;
e->page = a;
What do you think?
Cheers,
Angelo.
---
[1] http://gcc.gnu.org/ml/gcc/2008-07/msg00133.html