This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, Fortran] [committed] PING: Extend gfc_code internal documentation


Tobias Burnus wrote:
Hi Daniel,

Daniel Kraft wrote:
Are there any comments on that one?
Looks OK. Thanks for your fantastic work. Sorry that we don't do timely reviews, but somehow real life continues to interfere :-(
Besides, I have the feeling that you know by now more about several part of gfortran than some of us does ;-)



Some comments from a non-native speaker:


+This statement-block will be represented in the internal gfortran tree like
+this, were the horizontal link-chains are those induced by the @code{next}



Instead of "like this" I'd use "as follows".


+next @code{ELSEIF} or @code{ELSE} block if there's a chain of them.
+
+@subsection Loops


I'd add another empty line to make it easier to find the @subsections.


+@code{op} member set to @code{EXEC_IF}. This structure's @code{block}
+member must point to another @code{gfc_code} node being the header of the
+if-block. This header's @code{op} member must be set to @code{EXEC_IF}, too,


Instead of "being", I'd use "which is".

Checked in with the suggested changes as revision 137226.


Thanks,
Daniel

--
Done:     Bar-Sam-Val-Wiz, Dwa-Elf-Hum-Orc, Cha-Law, Fem-Mal
Underway: Ran-Gno-Neu-Fem
To go:    Arc-Cav-Hea-Kni-Mon-Pri-Rog-Tou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]