This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [PATCH, Fortran] PING: Extend gfc_code internal documentation
- From: Tobias Burnus <burnus at net-b dot de>
- To: Daniel Kraft <domob1812 at gmail dot com>
- Cc: Fortran List <fortran at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 27 Jun 2008 10:41:02 +0200
- Subject: Re: [PATCH, Fortran] PING: Extend gfc_code internal documentation
- References: <485E4DA2.4010902@domob.eu> <4863A52B.1080304@domob.eu>
Hi Daniel,
Daniel Kraft wrote:
Are there any comments on that one?
Looks OK. Thanks for your fantastic work. Sorry that we don't do timely
reviews, but somehow real life continues to interfere :-(
Besides, I have the feeling that you know by now more about several part
of gfortran than some of us does ;-)
Some comments from a non-native speaker:
+This statement-block will be represented in the internal gfortran tree like
+this, were the horizontal link-chains are those induced by the @code{next}
Instead of "like this" I'd use "as follows".
+next @code{ELSEIF} or @code{ELSE} block if there's a chain of them.
+
+@subsection Loops
I'd add another empty line to make it easier to find the @subsections.
+@code{op} member set to @code{EXEC_IF}. This structure's @code{block}
+member must point to another @code{gfc_code} node being the header of the
+if-block. This header's @code{op} member must be set to @code{EXEC_IF}, too,
Instead of "being", I'd use "which is".
Tobias,
who had this week his doctoral defense