This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fortran: PR/34908, PR/36276: do not free current_file->filename if it changes

From: Tobias Burnus <burnus at net-b dot de>
To: Laurynas Biveinis <laurynas dot biveinis at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
Date: Fri, 20 Jun 2008 15:50:57 +0200
Subject: Re: [PATCH] Fortran: PR/34908, PR/36276: do not free current_file->filename if it changes
References: <d1e3ff2b0806200530s15b7b0d1w45c997f80def6b3e@mail.gmail.com>

Laurynas Biveinis wrote:

Hi,

The "old" current_file->filename is referenced by linemap, thus it
cannot be freed at this point. The proper fix probably would be to
update linemap with the new filename, but in any case this trivial
patch is an improvement. This change is already suggested by a comment
in PR/36276, I arrived at it independently by investigating PR/34908.
Bootstrapped/regtested Fortran on trunk on x86_64-unknown-linux-gnu,
OK for trunk? OK for 4.3 branch after bootstrapping/regtesting there?

2008-06-20 Laurynas Biveinis <laurynas.biveinis@gmail.com>

PR fortran/34908, fortran/36276 * scanner.c (preprocessor_line): Do not call gfc_free for current_file->filename if it differs from filename.

My patch, err your patch* is OK. :-)

But as Daniel already wrote, please change PR lines in the change log to:

       PR fortran/34908
	PR fortran/36276

Tobias

(* I did the functionally identical patch in PR 36276.)

References:
- [PATCH] Fortran: PR/34908, PR/36276: do not free current_file->filename if it changes
  - From: Laurynas Biveinis

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]