This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [PATCH] Fortran: PR/34908, PR/36276: do not free current_file->filename if it changes
- From: "Laurynas Biveinis" <laurynas dot biveinis at gmail dot com>
- To: "Daniel Franke" <franke dot daniel at gmail dot com>
- Cc: fortran at gcc dot gnu dot org
- Date: Fri, 20 Jun 2008 15:46:31 +0200
- Subject: Re: [PATCH] Fortran: PR/34908, PR/36276: do not free current_file->filename if it changes
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=KvyYo2tSTMdcusKm5Jj6CyvNwKnY2g9xs9haPzh3SsE=; b=wb7hhEYMwMqC4DPQEUpkvMnd+txEAKXTmY7wp8f1HC9rLtpwKOS2564lGAJOmu9+Eu 2CqkJAAJUlUNTFaPXGvYbHukBMnTy4idggbXOH7mXRwWaQd4jzZ0ymaOWtcTNDLmwZvI 6cWGUORH6RzFf/eVHTNsztfDNOBSdqFPEVJYc=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=wV7c+rbEHsgYi38wzVxPUrQmfDEUaUOLe7kNazaaQ6pz42j40gU/04nYXgYmhSbE6/ ehGYZLSS13eLJiwCWnF+EHK5QU/Qu+JIHz/cqLNftaHY80/NUkDTLH/6bNE6BM3j6ItX r0/sj4njD6HUbMqjw65Z2kkuDVkJenguKSGOg=
- References: <d1e3ff2b0806200530s15b7b0d1w45c997f80def6b3e@mail.gmail.com> <640ad44b0806200540w1f7c5081g9d43eddb323ad798@mail.gmail.com>
2008/6/20 Daniel Franke <franke.daniel@gmail.com>:
>> 2008-06-20 Laurynas Biveinis <laurynas.biveinis@gmail.com>
>>
>> PR fortran/34908, fortran/36276
>> * scanner.c (preprocessor_line): Do not call gfc_free for
>> current_file->filename if it differs from filename.
>
> Make this
> PR fortran/34908
> PR fortran/36276
> to make everybody happy :)
OK, committing to the trunk and to the 4.3 after test there...
> Btw, this might be a cure for PR36342 as well. I'll try to check if I
> can find the time ...
I checked that PR and the valgrind output is clean now, and the
valgrind backtrace in comment #1 definitely points to the same issue.
I did not test without the patch to see those errors though. I will
add note to that PR after commit. I cannot decide that this PR could
be closed as well, as probably real file names in diagnostics should
be reported instead of /tmp/... . This would require exactly the
change the FIXME in the patch suggests.
Thanks,
--
Laurynas