This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] fix recent bootstrap breakage on darwin

From: Paolo Bonzini <bonzini at gnu dot org>
To: Daniel Franke <franke dot daniel at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org, Dominique Dhumieres <dominiq at lps dot ens dot fr>, Andreas Tobler <andreast-list at fgznet dot ch>
Date: Thu, 29 May 2008 11:34:45 +0200
Subject: Re: [patch] fix recent bootstrap breakage on darwin
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding:sender; bh=WtZLVrT99J2L+4vvVoNf9MfW1et9/VT3RwkcDUigpnA=; b=Ms5pD1N50bCc5GoPRV8/qZ9K2RpEP3w0oxinxlHiBAZSODTsPuHnZRnWZvOCXEsT9CqLx+tNa1Ik4v8F9kAASBaPQxqlNee1+E2cApw24aPYVLjEAGVh6gbkIndp4BIHHB4Sm+BAFQp7XVqGnzVgs6BNulkbf9kGkUxpyKQWezY=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding:sender; b=Wzl/qC3TyCoq8ez92tN3+jIo/8ung11n1i/9Ufq5Jw5DB1BL7Jz2MVwQaCHMpnmTy8zjijNiJW2qW2yPnrcnZ8pMveRfv8egbcqPeoApcOvhHtheYNMapii/g4NCKJK1oG9SFfjGQiB79w5ONg3LkRTsYPEWAvAy8DUob4pbR5w=
References: <200805280857.37725.franke.daniel@gmail.com> <483E7014.7030303@gnu.org> <640ad44b0805290217k5a618e11haadf96f4263f70a1@mail.gmail.com>

How about committing the partial fix as is (including Andreas'
snippet) to get darwin bootstrap going again and implementing this as
an afterthought? There seems to be no obvious problem with omitting
the two functions for now (meaning that the problem lies deeper and is
more nasty)?

No, there is no obvious problem indeed, but it's a matter of cleanness.

Since darwin-f.c is totally trivial, go ahead even though I cannot approve it -- fix its comment as indicated by Steven, and commit to unbreak bootstrap. Also make sure you consider the changes that Andreas needed.

Still, I'd appreciate that you commit (as much as that is possible in a free software project) to fix the issue properly soonish.

Paolo

References:
- [patch] fix recent bootstrap breakage on darwin
  - From: Daniel Franke
- Re: [patch] fix recent bootstrap breakage on darwin
  - From: Paolo Bonzini
- Re: [patch] fix recent bootstrap breakage on darwin
  - From: Daniel Franke

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]