This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [patch] fix recent bootstrap breakage on darwin
- From: "Daniel Franke" <franke dot daniel at gmail dot com>
- To: "Paolo Bonzini" <bonzini at gnu dot org>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org, "Dominique Dhumieres" <dominiq at lps dot ens dot fr>, "Andreas Tobler" <andreast-list at fgznet dot ch>
- Date: Thu, 29 May 2008 11:17:36 +0200
- Subject: Re: [patch] fix recent bootstrap breakage on darwin
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=LCiiCfK2ostZDJRH4i8RkgjYQlpQMoe4OXcCrIHQZHg=; b=XvKXnvSkVGxKaLPt7tbWarNc9N1tze+p4DWGTB7TUPyc+FbeExZD/p1oAe0KMqrnofJrDy6ohkj6uDUF/2obGZK/PDugCkSUpphNuUf+aPMfwBzNUPbku80efP0N9QrHrwx5h3UK8A60zG3g4RbjEjU7XbZlfhPn8iYldm4wIEM=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=i0ulklKNw8y9S5mMxyyyMlKDPKvwHTRA8iMY4ON3NAq7MBeiH7uIR+mdtLrPq2WZylBxEyZtEpg4Os7hdQxQK4vplETzhL9N17WLfpUKOrDQOtD//SANZOaha+NTia6ybE0svViWsBDBaMYeVBl/jjb2ooCf+XfPjl2AJSTLMVk=
- References: <200805280857.37725.franke.daniel@gmail.com> <483E7014.7030303@gnu.org>
2008/5/29, Paolo Bonzini <bonzini@gnu.org>:
>
>> * config.gcc: Defined new variable, fortran_target_objs.
>> (*-*-darwin*): Set fortran_target_objs.
>> * Makefile.in: Defined new variable FORTRAN_TARGET_OBJS.
>> * configure.ac: Substitute fortran_target_objs, set FORTRAN_TARGET_OBJS.
>> * configure: Regenerated.
>>
>> gcc/fortran:
>> 2008-05-29 Daniel Franke <franke.daniel@gmail.com>
>>
>> PR target/36348
>> * Make-lang.in (F95_OBJS): Added dependency on FORTRAN_TARGET_OBJS.
>
> These build parts are okay.
>
> However, I think that you actually need to implement
> darwin_register_frameworks, as well as the -iframework option
> implemented by handle_c_option in darwin-c.c. I suggest splitting that
> part of darwin-c.c into a new file darwin-cpp.c that is included in all
> three of c_target_objs, cxx_target_objs, fortran_target_objs.
>
> Furthermore, given that the target hook TARGET_HANDLE_C_OPTION is
> implemented only by darwin-c.c, it makes sense to rename it to
> TARGET_HANDLE_CPP_OPTION and call it from the Fortran front-end too.
How about committing the partial fix as is (including Andreas'
snippet) to get darwin bootstrap going again and implementing this as
an afterthought? There seems to be no obvious problem with omitting
the two functions for now (meaning that the problem lies deeper and is
more nasty)?
> It looks like you opened quite a Pandora's box! :-)
Dived in head first ^^
Thanks
Daniel