This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] fix recent bootstrap breakage on darwin

From: Paolo Bonzini <bonzini at gnu dot org>
To: Daniel Franke <franke dot daniel at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org, Dominique Dhumieres <dominiq at lps dot ens dot fr>, Andreas Tobler <andreast-list at fgznet dot ch>
Date: Thu, 29 May 2008 10:57:56 +0200
Subject: Re: [patch] fix recent bootstrap breakage on darwin
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; bh=vlJKcfQwX1eDDa5Buy7nBXAupzO6HzWOA1kvhv5RAeY=; b=P42YCCtPWqqjHI/yFqlWgPoKgJ8DoXYTls9KFJY9m+OTlSeNRT/5GUGxaqWd1ci9EugVDBYQZGGxLN+7HLWfssyCS4uausPQJEs86uFPZo6Rb/bVL+9fsVGY8jcGwbfGHzxdE579IKIQQfzH7z6HU17vNyPEUKisN0/WCukUXnk=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding:sender; b=kdWTF9ILIY6v86CNdzuL4TzOJFqqgBujSpLJ8SpdZP5SYsFZRzpEEEZ1U9sSMazwz90XM50z/hXA18RfeacFgVQeGCUGcLi1+vBCvVYjOmfhGO9NbJ6dSrI6VBEubHbW0p0g7O6OweqIhJvJ53JfatPZo1/oUSJWE9/yGawgI7w=
References: <200805280857.37725.franke.daniel@gmail.com>

	* config.gcc: Defined new variable, fortran_target_objs.
	(*-*-darwin*): Set fortran_target_objs.
	* Makefile.in: Defined new variable FORTRAN_TARGET_OBJS.
	* configure.ac: Substitute fortran_target_objs, set FORTRAN_TARGET_OBJS.
	* configure: Regenerated.

gcc/fortran:
2008-05-29  Daniel Franke  <franke.daniel@gmail.com>

	PR target/36348
	* Make-lang.in (F95_OBJS): Added dependency on FORTRAN_TARGET_OBJS.

These build parts are okay.

However, I think that you actually need to implement darwin_register_frameworks, as well as the -iframework option implemented by handle_c_option in darwin-c.c. I suggest splitting that part of darwin-c.c into a new file darwin-cpp.c that is included in all three of c_target_objs, cxx_target_objs, fortran_target_objs.

Furthermore, given that the target hook TARGET_HANDLE_C_OPTION is implemented only by darwin-c.c, it makes sense to rename it to TARGET_HANDLE_CPP_OPTION and call it from the Fortran front-end too.

It looks like you opened quite a Pandora's box! :-)

Paolo

Follow-Ups:
- Re: [patch] fix recent bootstrap breakage on darwin
  - From: Daniel Franke

References:
- [patch] fix recent bootstrap breakage on darwin
  - From: Daniel Franke

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]