This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [fortran,patch] Last widechar intrinsics and a few related fixes
- From: FX <fxcoudert at gmail dot com>
- To: Tobias Burnus <tobias dot burnus at physik dot fu-berlin dot de>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Wed, 28 May 2008 22:12:23 +0100
- Subject: Re: [fortran,patch] Last widechar intrinsics and a few related fixes
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer; bh=kBadKG08aUYKOwTsiqQkT4O2One/bOaumLYYXMSSSAQ=; b=iKyaflkYRlDFnPqioLwqEeLi213rv+8MXW9WJUEsadFHJ+tYfHjcYB6T37ZzwZiC38M4eWC2RT7x1kO3kfZ7u20PfIvV1T8KaA7Npy+RscfxxXmPnSTAeyHoB4owRgzB7WUrVufXk5rO5+qHMRUqW9mQDamkGdBVjH7y3+d8sAQ=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer; b=VjB+OuANHd2FTuKB/7YvW77vraFwaKu2ac4KvSOSWNoxTmB3Abrm+pKhkxeZTR4S98dO0UnRW7qlaBAXgrSF/RBy+tOCZP++bj/0znZjRKQstFAcI+/IhHxnJDk3bqQL7yeXNYT4YssEaqMRta6YtEpwdlUg3kOByfsWzdG0czo=
- References: <20080528204822.GA6542@physik.fu-berlin.de>
if (sslen == 0)
- return 1;
+ return back ? (slen + 1) : 1;
Good catch!
I wrote the testcases in such a way that they compare the result of
simplification routines and the runtime result, which caught it.
+++ libgfortran/gfortran.map (working copy)
@@ -1065,6 +1065,27 @@ GFORTRAN_1.1 {
_gfortran_transpose_char4;
_gfortran_unpack0_char4;
_gfortran_unpack1_char4;
+ _gfortran_cshift0_1_char4;
Recently, we decided to sort this list (see Thomas' patch/Changlog
item).
OK, I will change that. But the list currently isn't strictly in
alphabetic order; if I use sort on it, it changes it that way:
@@ -1051,17 +1072,17 @@ GFORTRAN_1.1 {
_gfortran_pack_char4;
_gfortran_pack_s_char4;
_gfortran_reshape_char4;
- _gfortran_select_string_char4;
_gfortran_selected_char_kind;
+ _gfortran_select_string_char4;
_gfortran_spread_char4;
_gfortran_spread_char4_scalar;
- _gfortran_st_wait;
_gfortran_string_index_char4;
_gfortran_string_len_trim_char4;
_gfortran_string_minmax_char4;
_gfortran_string_scan_char4;
_gfortran_string_trim_char4;
_gfortran_string_verify_char4;
+ _gfortran_st_wait;
_gfortran_transpose_char4;
_gfortran_unpack0_char4;
_gfortran_unpack1_char4;
(I've committed that sorted version.)
PS: Any plans for supporting UTF-8 source files (cf. -finput-
charset=)?
Yes, I intend to work on that.
FX
--
François-Xavier Coudert
http://www.homepages.ucl.ac.uk/~uccafco/