This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [patch, fortran] PR34325 Wrong error message for syntax error
- From: FX <fxcoudert at gmail dot com>
- To: Jerry DeLisle <jvdelisle at verizon dot net>
- Cc: Fortran List <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 5 May 2008 06:52:42 +0200
- Subject: Re: [patch, fortran] PR34325 Wrong error message for syntax error
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:to:mime-version:resent-cc:content-type:resent-date:message-id:cc:content-transfer-encoding:resent-to:from:subject:resent-from:resent-message-id:date:x-mailer; bh=luuH/39aInBfHYQa7dUjuZpEd291JcOUTtSGxfAeZgM=; b=fHUfTLLj4asOekp29NsF95OJwuEE5tCTrMQIzB4jichNcBmLwNkR8OdhmJKrr7rfQHLNYYbvtSxAeCx6GYxSUtigsxHYzHvGRUL7avmO9SkC0KulvC4Njsb4TcbXBtIuN4HVRnAIUZmBegYmEeGkMJ84OTWSaq7auV6eWAJ5GSA=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=to:mime-version:resent-cc:content-type:resent-date:message-id:cc:content-transfer-encoding:resent-to:from:subject:resent-from:resent-message-id:date:x-mailer; b=KPL9iys6bw4P763ooPGpEMSljkxxMCwah03Kdv+93034QxHKJjEk86OfJF8jRi+1rzXHpzhcPg8p0O6IttP8GYdDhvsjPyrgc5wI0Z5+B49TsvbaXZOQJOoAMU4nYS47QqbZ/ml/e4IZyyJPppPNx/tEAN/Kj0cpD9xopcuL4DQ=
2008-05-04 Jerry DeLisle <jvdelisle@gcc.gnu.org>
PR fortran/34325
* decl.c (match_attr_spec): Check for matching pairs of parenthesis.
* expr.c (gfc_specification_expr): Supplement the error message
with the
type that was found.
* resolve.c (gfc_resolve_index): Likewise.
* match.c (gfc_match_parens): Clarify error message with "at or
before".
(gfc_match_do): Check for matching pairs of parenthesis.
OK to commit. I think that generally these syntax-error and
diagnostic patches are rather hard to review in depth, as there are
really tons of ways they could do things we can't even imagine on
other invalid-code cases, so I tend to only review them for style,
wording and obvious mistakes; I hope it's OK.
FX
--
François-Xavier Coudert
http://www.homepages.ucl.ac.uk/~uccafco/