This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [patch, fortran] PR35156: deprecate -M
- From: Daniel Franke <franke dot daniel at gmail dot com>
- To: fortran at gcc dot gnu dot org
- Cc: Tobias Burnus <burnus at net-b dot de>, gcc-patches at gcc dot gnu dot org
- Date: Fri, 25 Apr 2008 23:18:02 +0200
- Subject: Re: [patch, fortran] PR35156: deprecate -M
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; bh=iGlzhI5z6FZqGPXB7tK3yswuWPPfIpaQbbNwPh9gKx4=; b=G6NHGUhjWLnnh6RA46y1wkqsp7YkWebTla1glbwwbZPCuR0Kk4WIh7lGEoqARmdlAjFHmFqum4VFQAGx/jYDtso4PkqhjwyqXXLWwmXkAHCdurZqtoAgl61ZuU13YeIxbjCe7i6KiOKqkLGtsS/kHx5+TBRQloMpx3ReI0OmtXo=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=jPbZMNAlQAGJrMLr2dpcbOG3hnO2iiD7kG0w0n2PtpnNvGTq+US3aNETVl7O4hTWssS5EOFcMANfEzveBDt8Y8glu/xQ5p2BjYHJLl9JbJetrSJkAEeY44TFzrQn6Yd1/adMM2hjZbqd8wLS3mZu26jsgUh0vqBRA6jVE6K+l3w=
- References: <200804242338.47388.franke.daniel@gmail.com> <4811A41E.9070105@net-b.de>
On Friday 25 April 2008 11:27:58 Tobias Burnus wrote:
> Daniel Franke wrote:
> > A very similar patch was already ok'ed [1], I just cleaned it up a bit.
> > If there are no objections, I'll commit it on Tobias' behalf in 24 hours.
>
> I believe you can also do the following change as in gfortranspec.c the
> argument "-M" is changed to "-J" and thus OPT_M should be not settable.
As lang.opt does not define "M", OPT_M should not be there to begin with.
Removed.
> At the moment I do not see whether we allocate enough memory with
> XNEWVEC (I could not quickly find that function/macro). For "-J" +
> "<dir>" we need 2+strlen("<dir>") + 1 bytes to accomodate also for the
> '\0'. Thus there might be one byte missing for:
Good eyes. Checked with valgrind and it showed a illegal read/write.
Fixed this.
With Jerry's ok committed as r134680.
Regards
Daniel