This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [patch, fortran] PR34556 Rejects valid with bogus error message: parameter initalization
- From: "Paul Richard Thomas" <paul dot richard dot thomas at gmail dot com>
- To: "Jerry DeLisle" <jvdelisle at verizon dot net>
- Cc: "fortran at gcc dot gnu dot org" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 15 Jan 2008 07:01:36 +0100
- Subject: Re: [patch, fortran] PR34556 Rejects valid with bogus error message: parameter initalization
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=gsGiuqOYBxn4I1/lhi4uA0gz+qRwsuK53LmChdYrMKs=; b=SUlwccX2WhrhCA7CLWUFVkVlD5CbJG0tFGEZ9i69SsXcGu3UXAFzPYECI0cjI1Ya4wQRQO1x6exPZFY1Goic3gTmsQFaHj1inSd8u97/F/eYCnkIPImNA/zY790yR5imbNWPFMlmgSbWLk95ip5VXfazmLJwORyX47VYVhmVGXY=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=v8f1bNZlb/R5s1LZ+4d/BXxDYld9yi2iTfv5RrG+Y9ApdS+KLIDdrXaPC/SRgCHfT45r31I/IJJ9/O7j4H/26N+xNJttKxe9JiSsiYlhCdLlkhf83C72N1ap4pJe0OXbgNr9sZdGSSH+iyfczlGl+zI19U8AqI66KJ7OwR0xf+0=
- References: <339c37f20801140108x6cbd52c4g37559d9cdcc94bcc@mail.gmail.com> <478C45A4.4090300@verizon.net>
Jerry,
I suggest that you make a local, renamed copy of gfc_is_constant_expr
and put the exclusion of functions in that. That'll make the patch
look a sight neater. Also, I guess that other transformational
functions need the same treatment?
Cheers
Paul
On Jan 15, 2008 6:33 AM, Jerry DeLisle <jvdelisle@verizon.net> wrote:
>
> Paul Richard Thomas wrote:
> >> OK for trunk?
> >
> > The patch fails if I change the order of the constructors in the
> > 'source' argument.
> >
> > integer, parameter, dimension (linem, nplam) :: nxttab = &
> > reshape ([[(6, i= 1, 2*linem) ], [(i, i= 1,linem)], &
> > max ([(i, i= 1,linem)], [(10*i, i= 1,linem)])], &
> > [linem, nplam ])
> >
> > I think that you are on the right track but a bit more is needed:)
> >
> > Cheers
> >
> > Paul
> >
> Paul, thanks for catching this. I will keep at it.
>
> Jerry
>
--
The knack of flying is learning how to throw yourself at the ground and miss.
--Hitchhikers Guide to the Galaxy