This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [fortran,patch] Don't write common more than once in a module file (PR 30285)
- From: FX Coudert <fxcoudert at gmail dot com>
- To: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- Cc: "fortran at gcc dot gnu dot org List" <fortran at gcc dot gnu dot org>, gcc-patches list <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 17 Nov 2007 13:47:02 +0000
- Subject: Re: [fortran,patch] Don't write common more than once in a module file (PR 30285)
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:in-reply-to:references:mime-version:content-type:message-id:cc:from:subject:date:to:x-mailer; bh=JUbTzm5LI9mBYJFmoegbqSKCLL8K8YhnLpOrwZ4DUDs=; b=oFFKqUcch8WOQmLe/QM9UJ1ON1kZV5l/eO4D3u8BIH6qhCXerKIq6nXEnmhjEhMxg+Vf2vqNTYCpjWj8f2Wm1WUXLjYAj695Tc2tAVD9BW+k54ySLVxNV+zuwfGjI+d76blvtoKI7Eda2Vly74QhHZ+gr5LWJBZ+sok3PitQ9p4=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:from:subject:date:to:x-mailer; b=mcqMjhBSJBpugnIb9CGRpmf0p22oXzLXmdG2l6v8NGQjHQ4gCo+KdmcTKEohG0hpOtH4GDgvqjuANMKp4D0HGk2tQ7wuXNyptq46gmqCxkTjlcgcrrxfrAqzSD4lwdU8qqQ04zzUGr5WUHE5VMTlOoaPZ96eYzdAMs79pO7gyww=
- References: <26954C8E-C987-4CD4-9887-310B6D00F004@gmail.com> <4735D4C2.6050102@physik.uni-muenchen.de> <F7B8D403-B274-4E0A-AF60-29ED89CAB022@gmail.com> <473E7F1E.6010503@physik.uni-muenchen.de> <473EEB22.2080007@physik.uni-muenchen.de>
Sorry, that I didn't think of this earlier. If you haven't
committed the patch yet, and since you're touching it, can you
please change the code to traverse the common tree in left-to-right
order in order to prevent spurious differences between module
files? Note that there's an early return in write_common0, so you
have to be a bit careful.
Here's what I've committed (using your recent change to write_symbol0
as a model for tree traversing) as rev. 130257.
FX
Attachment:
pr30285_3.diff
Description: Binary data