This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [fortran,patch] Getting rid of an ICE on ISNAN
- From: Richard Guenther <rguenther at suse dot de>
- To: François-Xavier Coudert <fxcoudert at gmail dot com>
- Cc: GFortran <fortran at gcc dot gnu dot org>, gcc-patches list <gcc-patches at gcc dot gnu dot org>, Andrew Pinski <pinskia at gmail dot com>
- Date: Tue, 30 Oct 2007 10:35:12 +0100 (CET)
- Subject: Re: [fortran,patch] Getting rid of an ICE on ISNAN
- References: <19c433eb0710291017r265c4f16vb842b6b65fe53cee@mail.gmail.com>
On Mon, 29 Oct 2007, François-Xavier Coudert wrote:
> When generating code for ISNAN(real-constant), we call
> build_call_expr() and get back an expression inside a NOP_EXPR, which
> is not expected, and leads to an ICE further in the middle-end. Using
> STRIP_TYPE_NOPS gets rid of the problem, even though it might be
> better to fix it in the middle-end. Andrew, Richard, you had ideas
> about this, do you want me to keep the PR open after this workaround
> is committed, and change its component to "middle-end"?
>
> Bootstrapped and regtested, with type checking, on x86_64-linux. OK to commit?
> FX
I think this is ok, even from a middle-end point of view (that is, until
we disentangle middle-end fold from frontend fold).
Richard.