This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gfortran, PR20851] Disallow dummy arguments in init exprs in elemental procedures


:REVIEWMAIL::

Tobias,
Fixing this issue turned out to be very simple, because valid expressions are folded by the simplifiers, i.e. the dummy argument doesn't appear in their simplified versions.
Hah! A good one...

The change to resolve_fl_variable() was necessary to avoid a double error message being printed: is_non_constant_shape_array(), in spite of its name suggesting otherwise, has side-effects and may issue errors, therefore I moved it to the end of the logical expressions in order to ensure that it's only called in cases where its result is important.
Ah, yes indeed.

Built and tested on i686-darwin. Ok?
OK

Thanks

Paul



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]