This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [PATCH]: Add -Wcast-qual to the bootstrap warning flags
- From: "Andrew Pinski" <pinskia at gmail dot com>
- To: "Kaveh R. GHAZI" <ghazi at caip dot rutgers dot edu>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Sun, 23 Sep 2007 21:17:32 -0700
- Subject: Re: [PATCH]: Add -Wcast-qual to the bootstrap warning flags
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=iiff/yeAorDHRWWSFwjRnDlRAk6/yNnJ6NgYmrusWZ8=; b=bAmBiGhemZPpEwyfluM40IHu3fFVIw5w4pmLDkWGcgzvztm0uTmuz6y1NXNQQdJgrWv1cVYjgZi3bG143EuIhflwRWW0r8Xm0fV0baObPTOOIgLoOWOxJd3nH59YU9qmlCbSyMzk+jq5KEiDfIeL0e3bcFgiLk0h+IKUeAcuexs=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=lkNEduOG9U91BqOOl2/GxHTVeiQqnKiyZWi8j/8xXJxmZMV78kHvDi5DX4473X+2ZdACMKCxU1/yrSZojOYAovLnkzN/AIh7lNi/1bvBMNX9Wn6dVInj02KwI+HnWIZiRzOFK/8QcptqXGx59kNfxGiwLyB6X72//PpSQ/6w6cY=
- References: <Pine.GSO.4.58.0709232333370.7689@caipclassic.rutgers.edu>
On 9/23/07, Kaveh R. GHAZI <ghazi@caip.rutgers.edu> wrote:
> + asprintf (CONST_CAST(char **, &m68k_library_id_string),
^
Missing space. Also this looks wrong anyways.
> + cselib_val *e = cselib_lookup (CONST_CAST_RTX(x), GET_MODE (x), 0);
Likewise.
> + cselib_val *e = cselib_lookup (CONST_CAST_RTX(y), GET_MODE (y), 0);
And again.
Can you double check all of the added CONST_CAST* to make sure they
have the needed space between the macro name and the parentheses?
Also why can't cselib_lookup take const_rtx? I think you need to take
more time to think about all of these const_* changes before just
adding CONST_CAST*.
Thanks,
Andrew Pinski