This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, Fortran] ABSTRACT INTERFACE


Hi Janus,

Janus Weil wrote:
> 2007-08-22  Janus Weil  <jaydub66@gmail.com>
>        * decl.c (match_attr_spec): Pass on errors from gfc_match_bind_c.
>        (gfc_match_bind_c): Bugfix in check for NAME= with abstract interfaces.
>   

I think the patch is ok, but you miss a test case. Please create a test
case (e.g. the one had above) with the needed "dg-" lines and possibly
some comments. Run then the regression test suite including your test
case. If it succeeds, write a changelog and send it and the test case
(either attached file or as diff).

The reason that we need a test case is to prevent that this problem
reappears in the future; it is extremely easy to break valid, existing
programs and the regression test suite tries to prevent this.

I often realized missing parts of the patch after I wrote a test case;
thus test cases are really useful when developing. You should share your
test cases with others even if you send only a draft version of the
patch. For the final patch submission they are mandatory. (Unless you
can argue why there should be no test case [e.g. untestable because it
crashes only with 1 TB files etc.].)

Tobias


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]