This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [patch, libgfortran] PR32611 Print sign of negative zero
- From: FX Coudert <fxcoudert at gmail dot com>
- To: Jerry DeLisle <jvdelisle at verizon dot net>, Janne Blomqvist <blomqvist dot janne at gmail dot com>
- Cc: Fortran List <fortran at gcc dot gnu dot org>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 15 Jul 2007 00:59:17 +0100
- Subject: Re: [patch, libgfortran] PR32611 Print sign of negative zero
- Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:in-reply-to:references:mime-version:content-type:message-id:cc:from:subject:date:to:x-mailer; b=mNTb7Wr6fAVuAY2fRhTwiDe33bKhqZS7WBdwq3zw14i5p11l9OIduL1FBKnP5cfqT6XAYkfGwxBobD/BJ61KCtFmGU6a7W9rQeA90mYafBgsYiH/rf0rZ2WDIlByinnej67jcVuPdmXW1XaYuofwETp1hC9ifPPyZkORwN0fRgg=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:from:subject:date:to:x-mailer; b=i4x/q1MMrhX/mHzqEfI0rIJQ2+qhMfEF0QxY5LIIPx9DKzxEIVZ/RjenP4V5C2p9pnjq+xJb0hUeYxMi0Nnc/XRzNBTZj3jBFtfnDX5aYK3KMMhmUxV1DQPMck5Kc6cz65dh7sbV6q5khBslZDqRg+TPsT/DfPbN6ZBS3SogFgo=
- References: <4691C8D6.7050703@verizon.net> <4699497F.1010800@verizon.net>
Hi Jerry, hi Janne, hi all!
I have provided a compile time flag, -fsign-zero that enables the
negative sign on zero values. This is the default behavior.
-fno-sign-zero disables the negative sign. Though probably never
used, it is there for anyone who comes upon an old application
where it might matter.
I plan to commit the patch today or tomorrow. The patch will
include fixes for test cases already submitted in the first patch I
gave in this thread.
I've sent my previous answer to your patch too fast, and after that
I've thought some more. I've read your patch, and it's OK to me if
you add documentation for the new option. Still, I think it would
really be great to integrate it with my patch changing the ABI for
passing compile-time options. To be completely honest, I am even more
interested in merging these patches that I will have intermitent
(unreliable) internet access during the next few days, and then will
be offline for a week in the beautiful but desert coutryside of
Ardèche (returning July 27th).
Thus, I've merged the two patches together and written a basic
ChangeLog (feel free to edit it). If you are OK with my part of the
patch, and let 48 hours for others (including Janne) to comment, then
I think we (and by this "we", I really mean "you" ;-) can safely
commit the patch, provided you write the little piece of missing
documentation.
Of course, if you feel that the task I'm imposing upon you is too
much of a burden, please feel free to commit your patch by itself and
let me worry later about the ABI change.
Cheers,
FX
Attachment:
compile_options.ChangeLog
Description: Binary data
Attachment:
compile_options.diff
Description: Binary data