This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gfortran,patch] Fix MVBITS calling conventions


On Wed, 2007-07-11 at 21:11 +0100, FX Coudert wrote:

:REVIEWMAIL:

Hi FX,

> Attached patch fixes the MVBITS intrinsic by changing the library  
> helper routine from:
>      SUB_NAME (const TYPE *from, const GFC_INTEGER_4 *frompos, const  
> GFC_INTEGER_4 *len, TYPE *to, const GFC_INTEGER_4 *topos)
> to:
>      SUB_NAME (const TYPE *from, const int *frompos, const int *len,  
> TYPE *to, const int *topos)
> 
> where TYPE is the integer kind type of the two main variables (TO and  
> FROM). I also changed the front-end so that the FROMPOS, LEN and  
> TOPOS variables are converted into the right kind, which was not done  
> before and caused wrong-code on big-endian targets (PR 32357).
> 
> Bootstrapped and regtested on x86_64-linux, OK for mainline?

This is OK, provided you add a non-empty ChangeLog entry and you
add the

! { dg-do run }

line to the test case.

	Thomas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]