This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [gfortran,patch] Fix MVBITS calling conventions
- From: Thomas Koenig <tkoenig at alice-dsl dot net>
- To: FX Coudert <fxcoudert at gmail dot com>
- Cc: "fortran at gcc dot gnu dot org List" <fortran at gcc dot gnu dot org>, gcc-patches List <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 14 Jul 2007 23:23:19 +0200
- Subject: Re: [gfortran,patch] Fix MVBITS calling conventions
- References: <B998287F-2BF3-4EB6-8564-8F3F2BC09448@gmail.com>
On Wed, 2007-07-11 at 21:11 +0100, FX Coudert wrote:
:REVIEWMAIL:
Hi FX,
> Attached patch fixes the MVBITS intrinsic by changing the library
> helper routine from:
> SUB_NAME (const TYPE *from, const GFC_INTEGER_4 *frompos, const
> GFC_INTEGER_4 *len, TYPE *to, const GFC_INTEGER_4 *topos)
> to:
> SUB_NAME (const TYPE *from, const int *frompos, const int *len,
> TYPE *to, const int *topos)
>
> where TYPE is the integer kind type of the two main variables (TO and
> FROM). I also changed the front-end so that the FROMPOS, LEN and
> TOPOS variables are converted into the right kind, which was not done
> before and caused wrong-code on big-endian targets (PR 32357).
>
> Bootstrapped and regtested on x86_64-linux, OK for mainline?
This is OK, provided you add a non-empty ChangeLog entry and you
add the
! { dg-do run }
line to the test case.
Thomas