This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,fortran] fix PR 32599 and PR 32601


hi Tobias,

thanks for the feedback. i'll try and remember to put the :ADDPATCH line in next time. do i need to change the spacing and ChangeLog issues you mentioned below and resubmit the patch?

thanks.
Chris

On Wed, 11 Jul 2007, Tobias Burnus wrote:

Hi Chris,

If you have ":ADDPATCH fortran:" on one line by itself, your patch is
automatically added to http://dberlin.org/patches/patches/list and as
link to the PRs.


Christopher D. Rickett wrote:
ChangeLog entry:
One usually splits the ChangeLog into one parts, one per
gcc/fortran/ChangeLog, gcc/testsuite/ChangeLog, libgfortran/ChangeLog.
Thus your it should be as follows:

2007-07-06 Christopher D. Rickett <crickett@lanl.gov>

    PR fortran/32599
    * decl.c (verify_c_interop_param): Require character string dummy
    args to BIND(C) procedures to have length 1.
    * resolve.c (resolve_fl_procedure): Modify parameter checking for
    BIND(C) procedures.

    PR fortran/32601
    * resolve.c (gfc_iso_c_func_interface): Verify that a valid
    expression is given as an argument to C_LOC and C_ASSOCIATED.
    * trans-io.c (transfer_expr): Add argument for code block.  Add
    standards check to determine if an error message should be
    reported for printing C_PTR or C_FUNPTR.
    (transfer_array_component): Update arguments to transfer_expr.
    (gfc_trans_transfer): Ditto.

* symbol.c (gen_cptr_param): Fix whitespace.


2007-07-06 Christopher D. Rickett <crickett@lanl.gov>


    PR fortran/32599
    * gfortran.dg/32599.f03: New test case.

    PR fortran/32601
    * gfortran.dg/32601.f03: New test case.
    * gfortran.dg/32601_1.f03: Ditto.
    * gfortran.dg/c_ptr_tests_9.f03: Updated dg-options.
    * gfortran.dg/c_ptr_tests_10.f03: Ditto.

symbol.c:


-      generate_isocbinding_symbol (module_name, ISOCBINDING_PTR,
+	generate_isocbinding_symbol (module_name, ISOCBINDING_PTR,
 				     (char *)c_ptr_type);
-
+
       gfc_get_ha_symbol (c_ptr_type, &(c_ptr_sym));

The last change adds tailing spaces.


+		}
+	    }
+
 	  /* We have to make sure that any param to a bind(c) routine does


Same here.


Otherwise OK.


Tobias



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]