This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [patch, fortran] PR31129 - warning on unused parameters
- From: "Daniel Franke" <franke dot daniel at gmail dot com>
- To: fortran at gcc dot gnu dot org
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 9 Jul 2007 14:36:56 +0200
- Subject: Re: [patch, fortran] PR31129 - warning on unused parameters
- Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=kE3uml1ZRKm5lPphN35N9LblJ+EO6aohBWsj+ESgA1iUgV7NQ9ido1RvPKiw550f/MkFV3xxEKRgGKdvou7UtjfeTFzu0kogcQ82Q3SjPdWwkEL+l1jEOYJKdnqDPSB9oXdGcLTTPN5gUKi+nOkvyTFTgPE1Z+Hu64mBco/zCXw=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:references; b=WpjYSDNvXqo8YQUV49PY60Wqk6np6IUHHhTh4lDLWDAu38GvD2P5zz08AFMrwszXPtqOCC9rv3G7Na3FI4NH83s6lW5OFBJvdks4fzryFKEl/Eq3bS4mIXOAtA5VYCl1aFzIwdPrZ+w71Z8jy/Y/HxDITYrhnqn3R78kWMU7Sco=
- References: <640ad44b0707090509p565ae078t37bda16bc6276eb1@mail.gmail.com>
Thanks Thomas, I try again ...
On -Wunused/-Wall , emit a warning if an unused parameters is found.
2007-07-09 Daniel Franke <franke.daniel@gmail.com>
PR fortran/31129
* trans-decl.c (generate_local_decl) Emit a warning if an unused
parameter is found.
2007-07-09 Daniel Franke <franke.daniel@gmail.com>
PR fortran/31129
* gfortran.dg/parameter_unused.f90: New test.
Regtested on i686-pc-linux-gnu. Ok for trunk?
Regards
Daniel
Index: trans-decl.c
===================================================================
--- trans-decl.c (revision 126478)
+++ trans-decl.c (working copy)
@@ -3035,6 +3035,14 @@
if (sym->attr.dummy && sym->backend_decl != NULL_TREE)
TREE_NO_WARNING(sym->backend_decl) = 1;
}
+ else if (sym->attr.flavor == FL_PARAMETER)
+ {
+ if (warn_unused_variable
+ && !sym->attr.referenced
+ && !sym->attr.use_assoc)
+ gfc_warning ("unused parameter '%s' declared at %L", sym->name,
+ &sym->declared_at);
+ }
if (sym->attr.dummy == 1)
{
Index: /home/daniel/svn/gcc/gcc/testsuite/gfortran.dg/parameter_unused.f90
===================================================================
--- /home/daniel/svn/gcc/gcc/testsuite/gfortran.dg/parameter_unused.f90 (revision 0)
+++ /home/daniel/svn/gcc/gcc/testsuite/gfortran.dg/parameter_unused.f90 (revision 0)
@@ -0,0 +1,9 @@
+! { dg-do compile }
+! { dg-options "-Wunused" }
+!
+! PR fortran/31129 - No warning on unused parameters
+!
+program fred
+integer,parameter :: j = 9 ! { dg-warning "unused parameter" }
+end
+