This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [Patch, fortran/libgfortran] ABI cleanup for ALLOCATE
- From: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- To: Jerry DeLisle <jvdelisle at verizon dot net>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 01 Jul 2007 15:09:51 +0300
- Subject: Re: [Patch, fortran/libgfortran] ABI cleanup for ALLOCATE
- Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=hODQtVbCXwrla8tbAjBDwnvxcaThX4jA8mtutfOpRf3ZOrWF5CHsDkzSj+iPEwDjFqzddlIQwnE/lHYT5hSs6C5joNT3nFAj/OAl6fFPK2Fufj8WzBv2jTTFwewB0if6r8oxtl7+CAqLkEdk9ycnuNq5SN6TNUsh18OJA+b5oLk=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=BGgH5xSZzqZlBf8jjLmpCWzCpfy/ITFBx8kYjk1+j3cucCdKpifI5gJFJ0Knb1wxwhzl6K5CtnY4AaMQymM3xg/D6MTZki2Cf7Rr5cs5onWetVNhTzF7lquJuGVTp8w0epitHy7UCko+ygv3Z2iia4gB2KTySU672QyXKPqtd9k=
- References: <46685B4F.3070707@gmail.com> <467C13F8.7070403@verizon.net> <467C1C24.9000401@verizon.net>
Jerry DeLisle wrote:
Jerry DeLisle wrote:
Janne Blomqvist wrote:
:ADDPATCH fortran:
Hi,
the attached patch does some ABI cleanup for the parts of libgfortran
that support the ALLOCATE statement. Currently we have separate
functions for 32 and 64-bit sizes. However, on 64-bit targets we
always use the 64-bit variants and on 32-bit targets we always use
the 32-bit variant. So it's a bit pointless (?) to keep both in the
library. The patch changes the frontend and library to use the
correct index_integer_type for sizes (the same type that array
descriptors use), and removes the 64-bit specific symbols.
As to why do something like this instead of fixing real bugs, now
that we have symbol versioning we have until the 4.3 release to do
whatever ABI fixing we want, after that we are stuck with supporting
the ABI for a while.
Regtested on i686-pc-linux-gnu. It would be nice if someone with a
64-bit system could test this, and also checking that generating
32-bit code using the 64-bit compiler works correctly. After that, Ok
for trunk?
Janne,
I am testing now. Patch went in clean so no bitrot. :)
Jerry
Regression tested OK on x86-64-Gnu/Linux.
OK for trunk.
Jerry
Thanks. Committed to trunk as r126166.
--
Janne Blomqvist