This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: new gfortran failures on darwin8
- From: Jerry DeLisle <jvdelisle at verizon dot net>
- To: Jack Howarth <howarth at bromo dot msbb dot uc dot edu>, toa at pop dot agri dot ch, Fortran List <fortran at gcc dot gnu dot org>
- Date: Wed, 27 Jun 2007 22:09:44 -0700
- Subject: Re: new gfortran failures on darwin8
- References: <20070626163450.GA13697@bromo.msbb.uc.edu> <46814E56.4020908@verizon.net> <20070628013551.GA27137@bromo.msbb.uc.edu>
Jack Howarth wrote:
Jerry,
We are still seeing these additional failures on
powerpc-apple-darwin8/9 with current gcc trunk.
Jack
On Tue, Jun 26, 2007 at 10:35:18AM -0700, Jerry DeLisle wrote:
My recent patch to change the error format to include the file name and
unit number may be the culprit. This touched on gfortran.h so you may need
to bootstrap and see if that fixes it.
If not, I will work with you to sort this out.
error_format is a new test case that went with the patch. read_comma I
never encountered a problem with.
Please try this simple patch first. If it does not work, let me know and I will
work on Plan B. :) The patch is to unit.c in libgfortran/io/
I see that find_unit sets the private lock of the unit and requires unlock_unit.
Why it works on some systems without the unlock I do not know.
Thanks for reporting and testing.
Jerry
Index: unit.c
===================================================================
--- unit.c (revision 125990)
+++ unit.c (working copy)
@@ -699,6 +699,7 @@ filename_from_unit (int unit_number)
{
filename = (char *) get_mem (u->file_len + 1);
unpack_filename (filename, u->file, u->file_len);
+ unlock_unit (u);
return filename;
}
else