This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

[Patch, fortran] PR32302 - [4.2/4.3 Regression] Incorrect result with -O2

From: "Paul Richard Thomas" <paul dot richard dot thomas at gmail dot com>
To: "Paul Brook" <paul at codesourcery dot com>, "Fortran List" <fortran at gcc dot gnu dot org>, "gcc-patches List" <gcc-patches at gcc dot gnu dot org>, "Andrew Pinski" <pinskia at gmail dot com>
Date: Thu, 14 Jun 2007 13:55:51 +0200
Subject: [Patch, fortran] PR32302 - [4.2/4.3 Regression] Incorrect result with -O2
Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:mime-version:content-type; b=sku+HSvIq0MKsbza/VMXUWmrhoFKHBVChDogTODhnpiQk5dTZrq5zljKWCEIOWmUd1lSp5bzX2Y8OegorYPsbPgJgyCu2f5Ql4EeI5ayRCx4LtzWA6C540lmwyYUY6n31H8K9inLZRgziKSuIIH4wBd2hEu8fo3DEKva8r+4Mgo=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:mime-version:content-type; b=arRbxhMiY9608aj/M6SvO+jPle95MHpN7NYvq79KkrE7WuhH1T+nNDM0hP3tg+BZYhugBXX04n2AIiM8w8X2JeDpLNQhLu5FHaoOUJsNe0cnjSEkqavGmoQeUJz0WE+YImCi32sfWtNhga5EZvYCpu57gttJtXWeiPjZ7YWqHLc=

:ADDPATCH fortran:

This was one of those happy moments where the solution came when I
turned to something else.  I notice that I did not add the PR number
to my previous posting - sorry!

Apparently, somewhere in the optimizer, the TREE_TYPE for the common
block declaration needs to be consistent with the size given by the
declaration.  This leads to the attached one line fix.  The testcase
is the reporter's, suitable embellished with DejaGnuery.

Regtested on Cygwin_NT/PIV - OK for trunk and 4.2?

Paul

2007-06-14 Paul Thomas <pault@gcc.gnu.org>

	PR fortran/32302
	* trans-common.c (build_common_decl): If resizing of common
	decl is needed, update the TREE_TYPE.

2007-06-14 Paul Thomas <pault@gcc.gnu.org>

	PR fortran/32302
	* gfortran.dg/common_resize_1.f90: New test.

Attachment: pr32302.diff
Description: Text document

Follow-Ups:
- Re: [Patch, fortran] PR32302 - [4.2/4.3 Regression] Incorrect result with -O2
  - From: FX Coudert

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]