This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [F-E, patch]: bug fixes for type components, etc.
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Brooks Moses <brooks dot moses at codesourcery dot com>
- Cc: "Christopher D. Rickett" <crickett at lanl dot gov>, fortran at gcc dot gnu dot org
- Date: Thu, 7 Jun 2007 19:35:48 -0700
- Subject: Re: [F-E, patch]: bug fixes for type components, etc.
- References: <Pine.LNX.4.64.0706071807571.30436@lennox.lanl.gov> <4668BBC3.5070700@codesourcery.com>
On Thu, Jun 07, 2007 at 07:15:31PM -0700, Brooks Moses wrote:
> Christopher D. Rickett wrote:
> >the attached patch mainly fixes bugs found by Tobias for bind(c) derived
> >types that have pointer/allocatable components.
>
> Hooray for bug-fixes!
>
> >Index: gcc/fortran/symbol.c
> >===================================================================
> >--- gcc/fortran/symbol.c (revision 125544)
> >+++ gcc/fortran/symbol.c (working copy)
> [...]
> >@@ -3181,8 +3187,8 @@ gen_special_c_interop_ptr (int ptr_id, c
> > generate_isocbinding_symbol (module_name, ptr_id ==
> > ISOCBINDING_NULL_PTR ? ISOCBINDING_PTR
> > : ISOCBINDING_FUNPTR,
> > (char *) (ptr_id ==
> > ISOCBINDING_NULL_PTR - ?
> >"_gfortran_iso_c_binding_c_ptr"
> >- : "_gfortran_iso_c_binding_c_funptr"));
> >+ ? "_gfortran_iso_c_binding_c_ptr" :
> >+ "_gfortran_iso_c_binding_c_funptr"));
> >
> > tmp_sym->ts.derived =
> > get_iso_c_binding_dt (ptr_id == ISOCBINDING_NULL_PTR
> >@@ -3723,8 +3729,8 @@ generate_isocbinding_symbol (const char
> > (mod_name, s == ISOCBINDING_FUNLOC
> > ? ISOCBINDING_FUNPTR : ISOCBINDING_FUNPTR,
> > (char *)(s == ISOCBINDING_FUNLOC
> >- ? "_gfortran_iso_c_binding_c_funptr"
> >- : "_gfortran_iso_c_binding_c_ptr"));
> >+ ? "_gfortran_iso_c_binding_c_funptr" :
> >+ "_gfortran_iso_c_binding_c_ptr"));
> > tmp_sym->ts.derived =
> > get_iso_c_binding_dt (s == ISOCBINDING_FUNLOC
> > ? ISOCBINDING_FUNPTR
>
> These two changes appear to just be introducing formatting errors, and
> they weren't mentioned in the ChangeLog. I presume they were included
> accidentally?
>
Yes, these are accidentally reverting one of my formatting changes.
Christopher, I'll take care of fixing this before I commit the
patch.
--
Steve