This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: RFC: Renaming 'enum gfc_generic_isym_id'
- From: Daniel Franke <franke dot daniel at gmail dot com>
- To: fortran at gcc dot gnu dot org
- Cc: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- Date: Mon, 28 May 2007 18:54:37 +0200
- Subject: Re: RFC: Renaming 'enum gfc_generic_isym_id'
- Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=hi5FerK7jHZQHQ3+tcZtb2p8JwPwfCyfvC0xuF/oA1OPUkkDON0nkyw4Li8DbY48s89h4TuOv0q/tGesy1J1B7ffJAdzj4i8uvAd7BWGAaY/tcGIdCpexElLV0d9DwIqEzkhlAkhtMeFxrtXLVPDQZre/fixpmrtLmuXQqhjk2I=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=AjuEOb5iAKfnOSgTmM6BrkgXEUGFm8syAZzSueA15+QMbI3f5uTyivdnXnBmZSuHlopGllGR/unlD7Rjy6ajI0mib/yZUhYASQggBZqqufFUtkTCCC5OHP7htOOxXTSzoysRxly1NRg6O1dz7UT2oQTKt8avHg0AI6aRlLs/g7M=
- References: <200705281157.52899.franke.daniel@gmail.com> <20070528164204.GB87124@troutmask.apl.washington.edu>
On Monday 28 May 2007 18:42:04 Steve Kargl wrote:
> On Mon, May 28, 2007 at 11:57:52AM +0200, Daniel Franke wrote:
> > (1) rename 'enum gfc_generic_isym_id' to 'enum gfc_isym_id'
> > (2) add missing intrinsics to 'enum gfc_isym_id'
> > (3) add an additional 'id' argument to 'add_sym_[012345][s]'
> > (4) change all callers, add the corresponding 'gfc_isym_id'
> > (5) rename member 'generic_id' in 'struct gfc_intrinsic_sym' to 'id'
> > (6) change all callers
> >
> > As especially (4) takes some time and effort I'd like to know whether
> > there are any objections to this, maybe an implication I missed?!
>
> Just for clarification. You want to add, for example,
> GFC_ISYM_ABS, GFC_ISYM_CABS, GFC_ISYM_DABS, and GFC_ISYM_ZABS.
> Will this have any performance impact on the switch statements
> in trans-intrinsic.c
I didn't intent to. I want to add GFC_ISYMs for subroutines, e.g.
GFC_ISYM_SLEEP. The generic aspect shall not be lost, i.e. any specific name
of ABS shall still have an id of GFC_ISYM_ABS.
Eventually, I want to switch over subroutines as it is done with functions in
trans-intrinsic.c (gfc_conv_intrinsic_function).