This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: RFC: Renaming 'enum gfc_generic_isym_id'
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Daniel Franke <franke dot daniel at gmail dot com>
- Cc: fortran at gcc dot gnu dot org
- Date: Mon, 28 May 2007 09:42:04 -0700
- Subject: Re: RFC: Renaming 'enum gfc_generic_isym_id'
- References: <200705281157.52899.franke.daniel@gmail.com>
On Mon, May 28, 2007 at 11:57:52AM +0200, Daniel Franke wrote:
>
> Hi all,
>
> in order to fix PR29651 et al., I want to distingiush between intrinsic
> subroutines. Currently all subroutines have isym->generic_id == GFC_ISYM_NONE
> which is not very helpful in this respect.
>
> To define a unique identifier for any intrinsics, I'd like to propose the
> following changes:
>
> (1) rename 'enum gfc_generic_isym_id' to 'enum gfc_isym_id'
> (2) add missing intrinsics to 'enum gfc_isym_id'
> (3) add an additional 'id' argument to 'add_sym_[012345][s]'
> (4) change all callers, add the corresponding 'gfc_isym_id'
> (5) rename member 'generic_id' in 'struct gfc_intrinsic_sym' to 'id'
> (6) change all callers
>
> As especially (4) takes some time and effort I'd like to know whether there
> are any objections to this, maybe an implication I missed?!
>
Just for clarification. You want to add, for example,
GFC_ISYM_ABS, GFC_ISYM_CABS, GFC_ISYM_DABS, and GFC_ISYM_ZABS.
Will this have any performance impact on the switch statements
in trans-intrinsic.c
--
Steve