This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: RFC: Renaming 'enum gfc_generic_isym_id'
- From: Daniel Franke <franke dot daniel at gmail dot com>
- To: fortran at gcc dot gnu dot org
- Cc: Bud Davis <bdavis9659 at sbcglobal dot net>
- Date: Mon, 28 May 2007 17:46:00 +0200
- Subject: Re: RFC: Renaming 'enum gfc_generic_isym_id'
- Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=RW0r+XLLKd9bP6eKspQsb4IfVoS1OAe7jHNufKdyd1lt2YxcRgLV+nBwqP3JMiNiqXc0b/BzPMdlXTJxzWflkUon3eujQ4gMAccKVJZtLQvvU0F86t51JO64d4SyjdWokLqRiVbxlue+p+QMz0PKAgx4vWakcyAIN25Y67fAr1k=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=nl/xXJainV7bVEa2xiT7dZWEPRrzlLyxi0FFbpvwgmFO0KUdXRdsVgm2MrU0ky0AbnCrbuuXxhLIPR/9mNjsw3AMvwTBLqAqbrTHMz/abdPH2JwuhL3Rkq5ZHrvv2xGRRkUQ+lUw51s6IdcxzYu6CxTBjpNlTNczNa429fC3yGE=
- References: <282934.45341.qm@web81207.mail.mud.yahoo.com>
On Monday 28 May 2007 17:17:41 Bud Davis wrote:
> --- Daniel Franke <franke.daniel@gmail.com> wrote:
> > (1) rename 'enum gfc_generic_isym_id' to 'enum> gfc_isym_id'
> > (2) add missing intrinsics to 'enum gfc_isym_id'
> > (3) add an additional 'id' argument to 'add_sym_[012345][s]'
> > (4) change all callers, add the corresponding 'gfc_isym_id'
> > (5) rename member 'generic_id' in 'struct gfc_intrinsic_sym' to 'id'
> > (6) change all callers
>
> suggestion: make this change seperate from fixing any
> PR or changing any functionality. then it is much
> easier to see what is important and what is not when
> looking at diff's.
This is what I had in mind :)
> overall, i love your idea. while you are doing this,
> you may want to make sure the difference between
> generic and others is not lost....the previous names
> mentioned generic and the significance might be
> important...something to think about.
Over all source files (gcc/fortran/*.[ch]), 'generic_id' is used 25 times,
most notably as an argument to switch (11 times). As far as I see, all of
them could easily work on 'id' as they do with 'generic_id'. The generic
aspect stems from intrinsic.c (make_generic) where functions as ABS are
overloaded with specific names as CABS, DABS, ... . There is no such
genericity with subroutines. Thus, I think we would not loose any information
if the 'generic' part of the name is removed. But the point you raise is the
reason for the request: the hive-mind may know better.
I'll go ahead and prepare a patch following the outline given above. A patch
tells more than vague descriptions.
Regards
Daniel