This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: RFC: Renaming 'enum gfc_generic_isym_id'
- From: Bud Davis <bdavis9659 at sbcglobal dot net>
- To: Daniel Franke <franke dot daniel at gmail dot com>, fortran at gcc dot gnu dot org
- Date: Mon, 28 May 2007 08:17:41 -0700 (PDT)
- Subject: Re: RFC: Renaming 'enum gfc_generic_isym_id'
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=sbcglobal.net; h=X-YMail-OSG:Received:Date:From:Subject:To:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; b=U3nkn9zeETZ60yqxJu5uUn0vJZLcgtdpxKD+1lPps/RmJd48fHtnt5bDIYU1FX3MmzZWDLKBD3cRax4Po+EG6g7wa5gJbNKVXwtUnUrw+zQGD9nDzC6nCuKpmuB532dsiAYAKE+59+HrZNCfg4xBvLbATcUOpv8XuWdWYnDeljk=;
--- Daniel Franke <franke.daniel@gmail.com> wrote:
>
> Hi all,
>
> in order to fix PR29651 et al., I want to
> distingiush between intrinsic
> subroutines. Currently all subroutines have
> isym->generic_id == GFC_ISYM_NONE
> which is not very helpful in this respect.
>
> To define a unique identifier for any intrinsics,
> I'd like to propose the
> following changes:
>
> (1) rename 'enum gfc_generic_isym_id' to 'enum
> gfc_isym_id'
> (2) add missing intrinsics to 'enum gfc_isym_id'
> (3) add an additional 'id' argument to
> 'add_sym_[012345][s]'
> (4) change all callers, add the corresponding
> 'gfc_isym_id'
> (5) rename member 'generic_id' in 'struct
> gfc_intrinsic_sym' to 'id'
> (6) change all callers
>
> As especially (4) takes some time and effort I'd
> like to know whether there
> are any objections to this, maybe an implication I
> missed?!
>
> Thanks
> Daniel
>
>
suggestion: make this change seperate from fixing any
PR or changing any functionality. then it is much
easier to see what is important and what is not when
looking at diff's.
overall, i love your idea. while you are doing this,
you may want to make sure the difference between
generic and others is not lost....the previous names
mentioned generic and the significance might be
important...something to think about.
--bud