This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Fortran, Patch] PR31188 - Allow array dummy as range for constant arrays

From: FX Coudert <fxcoudert at gmail dot com>
To: Tobias Burnus <burnus at net-b dot de>
Cc: "'fortran at gcc dot gnu dot org'" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 15 Mar 2007 22:33:51 +0100
Subject: Re: [Fortran, Patch] PR31188 - Allow array dummy as range for constant arrays
Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer; b=rWihM1QD4OKdhjZ6X3AwzeglVIPvdUgFSO95wtmBpZt/8l+IUVb72oTl57xzkO+VpiECDWH+La9ONS+U+GwtgxLhRDQnOU45tDL5OsFga1nfrWpNboOBt5PqCWy8CNzd1o3ee17XNOtIvWoqrWMouGFcaEMCBw46gkl9ZbVnOw4=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer; b=oDtO5YmRhmNrx8lsWEjePS6z9lZZcXk9cOki1UBV9PaIC2gCjpJId2suQO60FhxFT41yITrRUPmJWe9FyMBRWdsw26AZZ8Zu8xGL9E5QEaW9DgRTNLFJtRNzafWKTTwxb51cg8V7l1DK5ON6Il629Q9bQXxv9k6KFPiecXR7XH8=
References: <45F9B189.1020608@net-b.de>

2007-03-15 Tobias Burnus <burnus@net-b.de>

	PR fortran/31188
	* expr.c (gfc_simplify_expr,find_array_section): Support
	  non-expression-constant variables.

Paul proposed another patch in the PR trail, which looks cleaner to me as it doesn't add the expr_const arg. Now I imagine there was a reason for you adding it in the first place, could you comment on Paul's patch (or could Paul comment on your patch)?

Otherwise, the reasoning looks OK, and I think when you both agree, you can go ahead and commit whatever it is you decided. (and, if both patches are equivalent, I'd prefer we don't add the expr_const argument).

Thanks for acting so fast,
FX

Follow-Ups:
- Re: [Fortran, Patch] PR31188 - Allow array dummy as range for constant arrays
  - From: Tobias Burnus

References:
- [Fortran, Patch] PR31188 - Allow array dummy as range for constant arrays
  - From: Tobias Burnus

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]