This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran] PR30554 - [4.2 and 4.1 only] ICE in mio_pointer_ref at module.c:1945

Steve,
I prefer the more complicated patch. From a future
maintenance standpoint (when pault isn't around), the
hidden symtree approach may mislead one into thinking
the hidden symtree has some magical importance. The
more complicated approach and its comments in the code
make it clear what is going on.
I would have added an explanatory comment. In fact, the example generates two "hidden" or "unique:" symtrees even with the patch - the array HESSIAN gets this treatment, as -fdump-parse-tree shows.

In fact, I wonder if some comments in module.c would not come amiss?

I have just committed the patch.

Cheers

Paul

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]