This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, Fortran] Use -huge()-1 as most negative integer for maxval/maxloc (PR30512)


Hi,

Brooks Moses wrote:
> This is why it's helpful for people to actually explain the
> differences they're suggesting!
Well, in this case it lead to a better comment. (I will use your version.)

> Also, I just noticed -- in your libgfortran patches, you end up using
> -HUGE-1 for both integers and reals.  I presume on reals that just
> ends up being the same as -HUGE?

I should have check this part better :-/
As m4 illiterate, I don't know how to fix this properly (I will try to
find out nonetheless); seemingly the following line by Thomas didn't work:

  
define(atype_min,ifelse(rtype_letter,`i',`(-'atype_max`-1)',`-'atype_max))dnl

and possibly the following ifs don't work either:

m4/pow.m4:ifelse(rtype_letter,i,`dnl
m4/iparm.m4:define(rtype_ccode,ifelse(rtype_letter,`i',rtype_kind,rtype_code))dnl

(In the first case it is i, in the second it is `i' is this intended?)

Tobias


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]