This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [FORTRAN PATCH]: Improved integer SIGN intrinsic (& bug-fix)

From: FX Coudert <fxcoudert at gmail dot com>
To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
Cc: Roger Sayle <roger at eyesopen dot com>, fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
Date: Sat, 20 Jan 2007 17:52:34 +0100
Subject: Re: [FORTRAN PATCH]: Improved integer SIGN intrinsic (& bug-fix)
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:in-reply-to:references:mime-version:content-type:message-id:cc:content-transfer-encoding:from:subject:date:to:x-mailer; b=khnmdTE/t7RbQRANzRrcSf30LVs8iXNj7U4fBWG1Ldm68nFr2qi21DFxX0nLgwHVuYF7+h75U5mmTFjAjHolkzcMYhg1rpEhmeBfxjdT6cdJB62RjzDRyPm0P6kMSgM1LR8rI3tdSu3LpgtPOsURFPJDQG1tjahIxD8DY3ZCQaA=
References: <2125.208.41.78.162.1169251129.squirrel@mail.eyesopen.com> <8F1ADC02-76C7-48F2-A541-BF8D0F004AC7@gmail.com> <20070120164754.GA58692@troutmask.apl.washington.edu>

OK for 4.3 and 4.2, as is. Please also include in your commit the
attached testcase, that includes Brooks' testcase and Steve's
comment, as well as tests for the largest integer value of each
integer kind.


My comment on Brooks test does not apply because I misread his
code.  I sent Roger a private email that (ab)used the SAVE
attribute.

I believe that my testcase is OK from that point of view. I'm not giving the SAVE attribute to the function argument, but including another function that has an internal SAVEd variable.

FX

References:
- [FORTRAN PATCH]: Improved integer SIGN intrinsic (& bug-fix)
  - From: Roger Sayle
- Re: [FORTRAN PATCH]: Improved integer SIGN intrinsic (& bug-fix)
  - From: FX Coudert
- Re: [FORTRAN PATCH]: Improved integer SIGN intrinsic (& bug-fix)
  - From: Steve Kargl

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]