This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] PR 30381, PR 30420: Fix constant-folding in bitwise intrinsics


On Tue, Jan 09, 2007 at 09:52:19PM -0800, Brooks Moses wrote:
> Steve Kargl wrote:
> >OK with a few changes.  In a few places you have error messages of the
> >form
> >
> >+	gfc_error
> >+	  ("Magnitude of second argument of ISHFTC exceeds third argument "
> >+	   "at %L", &s->where);
> >
> >Please unwrap this to
> >
> >	gfc_error ("Magnitude of second argument of ISHFTC exceeds third
> >               "argument at %L", &s->where);
> >
> >Try 'grep gfc_error *.c' to see my justification for the request.
> >I'm trying to migrate gfortran source code to a uniform style.
> 
> Thanks!  Committed, as attached.  I noticed that there are some similar 
> error messages in gfc_simplify_ishft() and other nearby places that I 
> didn't touch, but I presume your in-progress series of whitespace 
> patches will get those?
> 

Yes, I get to those.

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]