This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [patch, fortran] PR30096 - Fixes for entity ambiguity and interfaces (PR29975, PR30068)
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Paul Thomas <paulthomas2 at wanadoo dot fr>
- Cc: Tobias Burnus <burnus at net-b dot de>, "'fortran at gcc dot gnu dot org'" <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 9 Dec 2006 11:01:30 -0800
- Subject: Re: [patch, fortran] PR30096 - Fixes for entity ambiguity and interfaces (PR29975, PR30068)
- References: <4579C0EE.6010403@net-b.de> <457A886D.9080809@wanadoo.fr>
On Sat, Dec 09, 2006 at 10:57:01AM +0100, Paul Thomas wrote:
> static int
> check_interface1 (gfc_interface * p, gfc_interface * q0,
> ! int generic_flag, const char *interface_name,
> ! int referenced)
I would prefer "bool referenced" because this ...
> {
> ! if (referenced)
is a logical expression and
> ! /* Originally, this test was aplied to host interfaces too;
> ! this is incorrect since host associated symbols, from any
> ! source, cannot be ambiguous with local symbols. */
> ! k = sym->attr.referenced || !sym->attr.use_assoc;
this is a logical expression.
Other than this nitpicking, the patch is OK.
--
Steve