This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix libgomp Fortran tests


On Thu, Sep 07, 2006 at 04:53:54PM -0700, Steve Kargl wrote:
> The attached patch fixes 2 problems in the libgomp testsuite.
> The Fortran tried to use the most negative integer value, but
> this cause an overflow because gfortran creates this value 
> via a unary minus operation.

> --- libgomp/testsuite/libgomp.fortran/reduction4.f90	(revision 116723)
> +++ libgomp/testsuite/libgomp.fortran/reduction4.f90	(working copy)
> @@ -12,7 +12,7 @@
>    ka = Z'05a5a5'
>    v = .false.
>    cnt = -1
> -  x = Z'ffffffff'
> +  x = - huge(x) - 1

This can't be right.  The test really needs an integer with all bits set,
-huge(x) - 1 is Z'80000000'.  That's what the OpenMP standard mandates
that iand reduction var should be initialized to.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]