Re: Status of allocatable components

[Erik Edelmann <erik dot edelmann at iki dot fi>]

On Wed, Jul 26, 2006 at 11:18:48PM +0300, Erik Edelmann wrote:
>     - trans-array.c (gfc_trans_deferred_array) for local
>       variables on procedure entry.
> 
>       FIXME: The comment on this function needs to be changed
>       slightly to reflect that it does DTWACs too.

Hm, actually, I think the comment is fine.

>     - trans-array.c (gfc_array_allocate) for newly allocated
>       arrays of DTWAC.
> 
>       CHECK: Shouldn't we do this for allocated scalars (e.g.
>       pointers) too?

Yes, we should.  Fixed.

>     - trans-expr.c (gfc_conv_function_call) for arguments that
>       are INTENT(OUT) or non-variable scalars (to be deallocated
>       before the call), or function results (after the call).
> 
>       CHECK: Shouldn't non-variables be deallocated after the
>       call too?

Yes, they should.  Fixed.

> CHECK: Do we need the rename + move of the function resolve.c
> (expr_to_initialize) --> expr.c (gfc_expr_to_initialize)?

No, we don't.  Change undone.

> FIXME: trans-array.c (copy_alloc_comp, deallocate_alloc_comp,
> nullify_alloc_comp) need a gfc_ prefix.

Fixed.

Latest version of the patch attached.


        Erik

Attachment: tr15581_0728.diff
Description: Text document