Re: [Patch, fortran] Inline DOT_PRODUCT

[Janne Blomqvist <jblomqvi at cc dot hut dot fi>]

On Mon, Feb 27, 2006 at 01:42:30PM +0100, THOMAS Paul Richard 169137 wrote:
> > I'm not that familiar with cygwin, but you might need the -msse2 flag
> > to tell the compiler that you actually have vector hw available,
> 
> This does not make any difference that I can see.
> 
> > otherwise it'll use x87 only. You might want -mfpmath=sse too just to
> 
> This option breaks the compiler - the executable does, well.... nothing.

Hmm, perhaps sse is broken on cygwin then? But I don't know much about
cygwin, so don't expect sensible advice from me on this matter.

> > make sure it doesn't waste time moving stuff between sse and x87 regs
> > (though I suspect your benchmark should be safe). And with
> > -ftree-vectorizer-verbose=5 you might get some additional info about
> > what the vectorizer is doing.
> 
> This gives me a "f951: error: unrecognized command line option
> "-ftree-vectorize-verbose=5"" for my pains.
                  ^^

You forgot the "r"?

But in any case, I agree with what others have said, we can further
investigate vectorization later if we want. The patch is fine as it
is, vectorization or not.

> > As for the patch itself, now that everything is done inline, can't one
> > get rid of gfc_resolve_dot_product entirely, or does it still do
> > something useful?
> 
> It is combining the expressions into an intrinsic expression and setting
> the type of the result.  This could be done elsewhere but the usage is
> consistent with other functions.

Ok, thanks for clarifying.

-- 
Janne Blomqvist

Attachment: pgp00000.pgp
Description: PGP signature