This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: PR 23902 -- fix scalar mask for minval/maxval/sum/product
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: Thomas Koenig <Thomas dot Koenig at online dot de>, fortran at gcc dot gnu dot org
- Date: Wed, 22 Feb 2006 08:26:33 +0100
- Subject: Re: PR 23902 -- fix scalar mask for minval/maxval/sum/product
- Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id:from; b=eg0x83NVXbdEsJJZEBazWK7qWyOmPpN4BIyWIrjEJh+Ylie+U0KyByMPkX10dIr4D0r3N5jbErQ44neBVf5WPCdfpL+GQIlYYz90bK8JdfLLnTV7JywlvaWzTZZfTViJZC37fLnA+mX+NjANfTI7s4lxBQYnRg4afdzhDv50ftU=
- References: <20060221230548.GA2989@meiner.onlinehome.de>
On Wednesday 22 February 2006 00:05, Thomas Koenig wrote:
> 2006-02-21 Thomas Koenig <Thomas.Koenig@online.de>
>
> PR fortran/23902
> * trans-intrinsic.c (gfc_conv_intrinsic_arith): If the
> mask expression exists and has rank 0, enclose the generated
> loop in an "if (mask)".
> * (gfc_conv_intrinsic_minmaxloc): Likewise.
>
> 2006-02-21 Thomas Koenig <Thomas.Koenig@online.de>
>
> PR fortran/23902
> scalar_mask_1.f90: New test.
I think you have the PR number wrong.
The subject of PR23902 is "update_ssa very very very slow", and even
though it would be great if that bug would be fixed, your patch does
not do that AFAICT ;-)
Gr.
Steven