This is the mail archive of the fortran@gcc.gnu.org mailing list for the GNU Fortran project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gfortran] Fix PRs 14771, 20894, 25048 : keep track of parentheses

From: Paul Thomas <paulthomas2 at wanadoo dot fr>
To: Tobias dot Schlueter at Physik dot Uni-Muenchen dot DE
Cc: THOMAS Paul Richard 169137 <paul dot richard dot thomas at cea dot fr>, zeekec at mad dot scientist dot com, fortran at gcc dot gnu dot org
Date: Fri, 10 Feb 2006 18:45:54 +0100
Subject: Re: [gfortran] Fix PRs 14771, 20894, 25048 : keep track of parentheses
References: <756DFD3DE8F1D411A59A00306E06E84702C429E3@drfccad.cad.cea.fr> <1139590275.43ecc48375b21@www.cip.physik.uni-muenchen.de>

Tobi,

I have fixed this a bit differently, as the check for !numeric_type is not necessary, due to INTRINSIC_PARENTHESES only being built around numeric expressions. If you prefer, I can streamline INTRINSIC_PARENTHESES to be handled the same as INTRINSIC_UPLUS everywhere, which makes some sense anyway.

I'll leave that to you - I would need to put my thinking cap on before deciding that they are exactly equivalent.

I did a grep to check that this is the only case where an INTRINSIC_PARNTHESES is not associated in some way with INTRINSIC_UPLUS. I think that all is well with this patch.

Hm, I found two more places, did you exclude them for some reason?

I found two places where they were well separated...

Patch including new testcase below, regtested with no new failures.

OK by me

Thanks

Paul

References:
- Re: [gfortran] Fix PRs 14771, 20894, 25048 : keep track of parentheses
  - From: THOMAS Paul Richard 169137
- Re: [gfortran] Fix PRs 14771, 20894, 25048 : keep track of parentheses
  - From: Tobias . Schlueter

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]