This is the mail archive of the
fortran@gcc.gnu.org
mailing list for the GNU Fortran project.
Re: [gfortran, patch] Obvious corrections to my PR 25716 patch
- From: Erik Edelmann <erik dot edelmann at iki dot fi>
- To: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 27 Jan 2006 12:43:46 +0200
- Subject: Re: [gfortran, patch] Obvious corrections to my PR 25716 patch
- References: <20060126221446.GA28939@acclab.helsinki.fi> <43D96CEC.7000404@physik.uni-muenchen.de>
On Fri, Jan 27, 2006 at 01:44:28AM +0100, Tobias Schlüter wrote:
> Erik Edelmann wrote:
> > static void
> > free_old_symbol (gfc_symbol * sym)
> > {
> > +
> > if (sym->old_symbol == NULL)
> > return;
>
> If this is the formatting error you're trying to fix, please don't. I think
> we all agree that this is ugly, and I distinctly remember rth speaking out
> against blank lines in the beginning of functions with no local varibles, so
> it's definitely not mandated.
Ok. I agree it's ugly, which is why I instinctively omitted the
empty line the first. Then I rembered seeing those empty lines
in the beginning of functions with no local varibles here and
there, but if it's OK to omit them, I'm happy to do so.
Erik